summaryrefslogtreecommitdiffstats
path: root/chrome/common
diff options
context:
space:
mode:
authorthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-17 12:30:34 +0000
committerthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-17 12:30:34 +0000
commit4f4863750ceccaa845e03eaf9768451c0db7e805 (patch)
treea4ca9e2271a4479c8b260ad2c6c065a522acbc07 /chrome/common
parent60a0af936fe4d0254a721de500e50b5ffa798b4d (diff)
downloadchromium_src-4f4863750ceccaa845e03eaf9768451c0db7e805.zip
chromium_src-4f4863750ceccaa845e03eaf9768451c0db7e805.tar.gz
chromium_src-4f4863750ceccaa845e03eaf9768451c0db7e805.tar.bz2
[Mac] more -Wextra support:
- autofill: explicitly initialize in the copy constructor - make some loops clearly use {} for empty bodies - bump up app mode version number to 1.0 so we don't check for < 0 on the unsigned version number. BUG=34160 TEST=none Review URL: http://codereview.chromium.org/2856006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50095 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r--chrome/common/app_mode_common_mac.h20
1 files changed, 10 insertions, 10 deletions
diff --git a/chrome/common/app_mode_common_mac.h b/chrome/common/app_mode_common_mac.h
index 48d72fe..046324ab 100644
--- a/chrome/common/app_mode_common_mac.h
+++ b/chrome/common/app_mode_common_mac.h
@@ -21,8 +21,8 @@ extern const CFStringRef kAppPrefsID;
extern const CFStringRef kLastRunAppBundlePathPrefsKey;
// Current major/minor version numbers of |ChromeAppModeInfo| (defined below).
-const unsigned kCurrentChromeAppModeInfoMajorVersion = 0;
-const unsigned kCurrentChromeAppModeInfoMinorVersion = 1;
+const unsigned kCurrentChromeAppModeInfoMajorVersion = 1;
+const unsigned kCurrentChromeAppModeInfoMinorVersion = 0;
// The structure used to pass information from the app mode loader to the
// (browser) framework. This is versioned using major and minor version numbers,
@@ -36,29 +36,29 @@ struct ChromeAppModeInfo {
unsigned minor_version; // Required: all versions
// Original |argc| and |argv|.
- int argc; // Required: v0.1
- char** argv; // Required: v0.1
+ int argc; // Required: v1.0
+ char** argv; // Required: v1.0
// Versioned path to the browser which is being loaded.
- char* chrome_versioned_path; // Required: v0.1
+ char* chrome_versioned_path; // Required: v1.0
// Information about the App Mode shortcut:
// Path to the App Mode Loader application bundle originally run.
- char* app_mode_bundle_path; // Optional: v0.1
+ char* app_mode_bundle_path; // Optional: v1.0
// Short ID string, preferably derived from |app_mode_short_name|. Should be
// safe for the file system.
- char* app_mode_id; // Required: v0.1
+ char* app_mode_id; // Required: v1.0
// Short (e.g., one-word) UTF8-encoded name for the shortcut.
- char* app_mode_short_name; // Optional: v0.1
+ char* app_mode_short_name; // Optional: v1.0
// Unrestricted (e.g., several-word) UTF8-encoded name for the shortcut.
- char* app_mode_name; // Optional: v0.1
+ char* app_mode_name; // Optional: v1.0
// URL for the shortcut. Must be a valid URL.
- char* app_mode_url; // Required: v0.1
+ char* app_mode_url; // Required: v1.0
};
} // namespace app_mode