Regkey functions return error code instead of bool

Change the Regkey helper to consistently use and return LONG
instead of bool.  Fix RegKey usage all over the code base and
get rid of workarounds due to lack of return value.

Reviewers:

brettw: everything (skip parts for other reviewers if you wish)
robertshield,grt: chrome_frame, installer
siggi: ceee


BUG=none
TEST=covered by existing tests



Review URL: http://codereview.chromium.org/6090006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 4 deletions

diff --git a/chrome/common/chrome_plugin_lib.cc b/chrome/common/chrome_plugin_lib.cc
index fb4ac83..e19a247 100644
--- a/chrome/common/chrome_plugin_lib.cc
+++ b/chrome/common/chrome_plugin_lib.cc
@@ -153,11 +153,11 @@ void ChromePluginLib::LoadChromePlugins(const CPBrowserFuncs* bfuncs) {
     reg_path.append(iter.Name());
     base::win::RegKey key(HKEY_CURRENT_USER, reg_path.c_str());
 
-    DWORD is_persistent;
-    if (key.ReadValueDW(kRegistryLoadOnStartup, &is_persistent) &&
-        is_persistent) {
+    DWORD is_persistent = 0;
+    key.ReadValueDW(kRegistryLoadOnStartup, &is_persistent);
+    if (is_persistent) {
       std::wstring path;
-      if (key.ReadValue(kRegistryPath, &path)) {
+      if (key.ReadValue(kRegistryPath, &path) == ERROR_SUCCESS) {
         ChromePluginLib::Create(path, bfuncs);
       }
     }