Add NotificationType::BROWSER_WINDOW_READY, chrome.windows.onCreated now sends full window

BUG=NONE

Review URL: http://codereview.chromium.org/195030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26771 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 20 insertions, 59 deletions

diff --git a/chrome/common/common_resources.grd b/chrome/common/common_resources.grd
index 5fc44f4..f7cb3ac 100644
--- a/chrome/common/common_resources.grd
+++ b/chrome/common/common_resources.grd
@@ -1,6 +1,4 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- This comment is only here because changes to resources are not picked up
-without changes to the corresponding grd file. rw -->
 <grit latest_public_release="0" current_release="1">
   <outputs>
     <output filename="grit/common_resources.h" type="rc_header">
diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json
index 1d49a6c..f9c5883 100755
--- a/chrome/common/extensions/api/extension_api.json
+++ b/chrome/common/extensions/api/extension_api.json
@@ -285,11 +285,9 @@
         "description": "Fired when a window is created.",
         "parameters": [
           {
-            "type": "object",
-            "name": "createInfo",
-            "properties": {
-              "id": {"type": "integer", "minimum": 0, "description": "ID of the new window."}
-            }
+            "$ref": "Window",
+            "name": "window",
+            "description": "Details of the window that was created."
           }
         ]
       },
diff --git a/chrome/common/extensions/docs/windows.html b/chrome/common/extensions/docs/windows.html
index 19bfa72..9291dc5 100755
--- a/chrome/common/extensions/docs/windows.html
+++ b/chrome/common/extensions/docs/windows.html
@@ -1875,7 +1875,7 @@ the value of the current window falls back to the topmost window.
 
               <div class="summary">
                 <!-- Note: intentionally longer 80 columns -->
-                <span class="subdued">chrome.windows.</span><span>onCreated</span><span class="subdued">.addListener</span>(function(<span>object createInfo</span>) <span class="subdued">{...}</span>);
+                <span class="subdued">chrome.windows.</span><span>onCreated</span><span class="subdued">.addListener</span>(function(<span>Window window</span>) <span class="subdued">{...}</span>);
               </div>
 
               <div class="description">
@@ -1888,7 +1888,7 @@ the value of the current window falls back to the topmost window.
                   <div jsinstance="*0">
                     <div>
           <dt>
-            <var>createInfo</var>
+            <var>window</var>
               <em>
 
                 <!-- TYPE -->
@@ -1896,50 +1896,14 @@ the value of the current window falls back to the topmost window.
                   (
                     <span class="optional" style="display: none; ">optional</span>
                     <span id="typeTemplate">
-                      <span style="display: none; ">
-                        <a> Type</a>
-                      </span>
                       <span>
-                        <span style="display: none; ">
-                          array of <span><span></span></span>
-                        </span>
-                        <span>object</span>
+                        <a href="windows.html#type-Window">Window</a>
                       </span>
-                    </span>
-                  )
-                </div>
-
-              </em>
-          </dt>
-          <dd class="todo">
-            Undocumented.
-          </dd>
-          <dd style="display: none; ">
-            Description of this parameter from the json schema.
-          </dd>
-
-          <!-- OBJECT PROPERTIES -->
-          <dd>
-            <dl>
-              <div jsinstance="*0">
-                <div>
-          <dt>
-            <var>id</var>
-              <em>
-
-                <!-- TYPE -->
-                <div style="display:inline">
-                  (
-                    <span class="optional" style="display: none; ">optional</span>
-                    <span id="typeTemplate">
                       <span style="display: none; ">
-                        <a> Type</a>
-                      </span>
-                      <span>
-                        <span style="display: none; ">
+                        <span>
                           array of <span><span></span></span>
                         </span>
-                        <span>integer</span>
+                        <span>paramType</span>
                       </span>
                     </span>
                   )
@@ -1950,7 +1914,7 @@ the value of the current window falls back to the topmost window.
           <dd class="todo" style="display: none; ">
             Undocumented.
           </dd>
-          <dd>ID of the new window.</dd>
+          <dd>Details of the window that was created.</dd>
 
           <!-- OBJECT PROPERTIES -->
           <dd style="display: none; ">
@@ -1962,10 +1926,6 @@ the value of the current window falls back to the topmost window.
             </dl>
           </dd>
         </div>
-              </div>
-            </dl>
-          </dd>
-        </div>
                   </div>
                 </dl>
 
diff --git a/chrome/common/notification_type.h b/chrome/common/notification_type.h
index 72e0d13..a11fa49 100644
--- a/chrome/common/notification_type.h
+++ b/chrome/common/notification_type.h
@@ -182,16 +182,21 @@ class NotificationType {
     // Browser-window ----------------------------------------------------------
 
     // This message is sent after a window has been opened.  The source is a
-    // Source<Browser> with a pointer to the new window.  No details are
+    // Source<Browser> containing the affected Browser.  No details are
     // expected.
     BROWSER_OPENED,
 
+    // This message is sent soon after BROWSER_OPENED, and indicates that
+    // the Browser's |window_| is now non-NULL. The source is a Source<Browser>
+    // containing the affected Browser.  No details are expected.
+    BROWSER_WINDOW_READY,
+
     // This message is sent after a window has been closed.  The source is a
-    // Source<Browser> with a pointer to the closed window.  Details is a
-    // boolean that if true indicates that the application will be closed as a
-    // result of this browser window closure (i.e. this was the last opened
-    // browser window).  Note that the boolean pointed to by Details is only
-    // valid for the duration of this call.
+    // Source<Browser> containing the affected Browser.  Details is a boolean
+    // that if true indicates that the application will be closed as a result of
+    // this browser window closure (i.e. this was the last opened browser
+    // window).  Note that the boolean pointed to by Details is only valid for
+    // the duration of this call.
     BROWSER_CLOSED,
 
     // This message is sent when the last window considered to be an