diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-01 16:59:11 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-01 16:59:11 +0000 |
| commit | df772cbfe7a1b17dd7bb179c1e25780201d0b0ce (patch) | |
| tree | bb2c277deb1b3ef07d04b5908e362c0ef7556478 /chrome/common | |
| parent | 8e0dca871966c15a08c23bfd890aad73ee3b8aa5 (diff) | |
| download | chromium_src-df772cbfe7a1b17dd7bb179c1e25780201d0b0ce.zip chromium_src-df772cbfe7a1b17dd7bb179c1e25780201d0b0ce.tar.gz chromium_src-df772cbfe7a1b17dd7bb179c1e25780201d0b0ce.tar.bz2 | |
More work fixing miscellaneous issues in the autocomplete code, probably none of which will help my crasher :(
* Force the query to stop if the user deletes a match. This makes more sense from a UI perspective and allows some code to be simpler.
* Prevent us from potentially doing a "minimal changes" match in a different profile (hard to trigger, likely no practical effects)
* Remove unneeded Reset() call on a repeating timer (which will auto-reset itself)
* Rename one of the notifications and move its listener to the edit, since that's who really cares about it anyway.
* Make the controller's Stop(true) notify the popup via the normal observer pipeline rather than coding something special into the popup's StopAutocomplete().
* Rename |paste_and_go_controller| |synchronous_controller| and use it instead of using the main popup controller to do the synchronous query when calling URLsForDefaultMatch(). This makes things both simpler and safer.
BUG=none
TEST=Using the omnibox still works fine
Review URL: http://codereview.chromium.org/178049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25044 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_type.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/chrome/common/notification_type.h b/chrome/common/notification_type.h index 97ec361..7625e51 100644 --- a/chrome/common/notification_type.h +++ b/chrome/common/notification_type.h @@ -551,11 +551,12 @@ class NotificationType { // observers should use if they want to see the updated matches. AUTOCOMPLETE_CONTROLLER_RESULT_UPDATED, - // Sent by the autocomplete controller once per query, immediately after - // synchronous matches become available. The details hold the + // Sent by the autocomplete controller immediately after synchronous matches + // become available, and thereafter at the same time that + // AUTOCOMPLETE_CONTROLLER_RESULT_UPDATED is sent. The details hold the // AutocompleteResult that observers should use if they want to see the - // synchronous matches. - AUTOCOMPLETE_CONTROLLER_SYNCHRONOUS_MATCHES_AVAILABLE, + // up-to-date matches. + AUTOCOMPLETE_CONTROLLER_DEFAULT_MATCH_UPDATED, // This is sent when an item of the Omnibox popup is selected. The source // is the profile. |