linux: build with -Wextra

95% of this is removing "const" from return types, but turning this
on found one bug!  (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)

BUG=34160

Review URL: http://codereview.chromium.org/570012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 5 insertions, 5 deletions

diff --git a/chrome/common/chrome_plugin_lib.h b/chrome/common/chrome_plugin_lib.h
index 0193708..5027cfc 100644
--- a/chrome/common/chrome_plugin_lib.h
+++ b/chrome/common/chrome_plugin_lib.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -43,7 +43,7 @@ class ChromePluginLib : public base::RefCounted<ChromePluginLib>  {
   static void UnloadAllPlugins();
 
   // Returns true if the plugin is currently loaded.
-  const bool is_loaded() const { return initialized_; }
+  bool is_loaded() const { return initialized_; }
 
   // Get the Plugin's function pointer table.
   const CPPluginFuncs& functions() const;
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 0e521c4..f1dbbfd 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -194,7 +194,7 @@ class Extension {
   const FilePath& path() const { return path_; }
   void set_path(const FilePath& path) { path_ = path; }
   const GURL& url() const { return extension_url_; }
-  const Location location() const { return location_; }
+  Location location() const { return location_; }
   void set_location(Location location) { location_ = location; }
   const std::string& id() const { return id_; }
   const Version* version() const { return version_.get(); }
diff --git a/chrome/common/extensions/user_script.h b/chrome/common/extensions/user_script.h
index e2b3a96..9fbbe89 100644
--- a/chrome/common/extensions/user_script.h
+++ b/chrome/common/extensions/user_script.h
@@ -70,7 +70,7 @@ class UserScript {
     void set_external_content(const base::StringPiece& content) {
       external_content_ = content;
     }
-    const void set_content(const base::StringPiece& content) {
+    void set_content(const base::StringPiece& content) {
       content_.assign(content.begin(), content.end());
     }