diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-04 21:57:21 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-04 21:57:21 +0000 |
| commit | 52e3f6aeeb805db5051f33f9fdf79671dbe839bc (patch) | |
| tree | d11816840a9f75b682c6cb2a1f905dfcaf135208 /chrome/common | |
| parent | 97c829370cf5d2a4679b18cb1a848074a17c3f1c (diff) | |
| download | chromium_src-52e3f6aeeb805db5051f33f9fdf79671dbe839bc.zip chromium_src-52e3f6aeeb805db5051f33f9fdf79671dbe839bc.tar.gz chromium_src-52e3f6aeeb805db5051f33f9fdf79671dbe839bc.tar.bz2 | |
Fix subtle memory issues detected by valgrind.
The size of dbus_bool_t and the size of bool are different.
The former is always 4, whereas the latter is usually 1.
The misuse of these types causes subtle memory issues
where some D-Bus functions read 4 bytes from a bool pointer,
or write 4 bytes to it. These functions take void* so
type checking didn't help.
TEST=tools/valgrind/valgrind.sh ninja/dbus_unittests
BUG=none
Review URL: http://codereview.chromium.org/7573001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95512 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
0 files changed, 0 insertions, 0 deletions