diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-16 19:16:38 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-16 19:16:38 +0000 |
| commit | ac02528c7082672bca70f67e72a74ee906507170 (patch) | |
| tree | 9328bc6dc30c1fb6ff1c66e461a4f09c70b51cd7 /chrome/common | |
| parent | f513d7b438b7f8d4a5551ca2f716f06374166b29 (diff) | |
| download | chromium_src-ac02528c7082672bca70f67e72a74ee906507170.zip chromium_src-ac02528c7082672bca70f67e72a74ee906507170.tar.gz chromium_src-ac02528c7082672bca70f67e72a74ee906507170.tar.bz2 | |
Only show gray LOADING dialog for Themes.
The patch changes the behavior of the LOADING dialog such that it is only shown for extension downloads from the mini-gallery (theme) url. Note that this means that themes from the chrome extensions gallery will also NOT have the dialog shown.
BUG=29628
TEST=Install an theme from https://tools.google.com/chrome/intl/pt/themes/index.html. The gray LOADING dialog should appear. Install extension or theme from chrome.google.com/extensions. No LOADING dialog should appear
Review URL: http://codereview.chromium.org/507016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34733 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_type.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/common/notification_type.h b/chrome/common/notification_type.h index 44b9519..dfd87f3 100644 --- a/chrome/common/notification_type.h +++ b/chrome/common/notification_type.h @@ -660,7 +660,9 @@ class NotificationType { // details are an Extension*, and the source is a Profile*. EXTENSION_UPDATE_DISABLED, - // Sent when a theme is ready to be installed, so we can alert the user. + // Sent when an extension is about to be installed so we can (in the case of + // themes) alert the user with a loading dialog. The source is the download + // manager and the details are the download url. EXTENSION_READY_FOR_INSTALL, // Sent on ExtensionOverinstallAttempted when no theme is detected. The |