diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-04 23:55:06 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-04 23:55:06 +0000 |
commit | cd3d789910d9bbd81c2a08eee26bffc4ae10ab52 (patch) | |
tree | 2d640336dd883be4f375540ea6573ede6fd3e732 /chrome/common | |
parent | 90f6e2e8b787268630fcecddd7542e1bfb587ab3 (diff) | |
download | chromium_src-cd3d789910d9bbd81c2a08eee26bffc4ae10ab52.zip chromium_src-cd3d789910d9bbd81c2a08eee26bffc4ae10ab52.tar.gz chromium_src-cd3d789910d9bbd81c2a08eee26bffc4ae10ab52.tar.bz2 |
Clean up the browser about URL handler to not derive from WebContents. It is
instead integrated in the BrowserURLHandler for special schemes. This solves
a number of problems and cleans things up nicely.
Most of the functions were not necessary to have in the header file of the
browser about handler, so I made them local to the .cc file. I moved everything
around, but there was no change to any of the About...() functions.
This improves the about:memory page to not include the memory of the new tab
page it replaced. The entry for itself also has the proper title. This works
by using a meta refresh to the actual page, the the process transition no longer
happens at the same time as the about:memory page computation.
This also fixes problems with the about:network and about:ipc dialogs opening
blank pages and also re-opening the dialog when you close the browser.
Review URL: http://codereview.chromium.org/27238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10941 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r-- | chrome/common/url_constants.cc | 6 | ||||
-rw-r--r-- | chrome/common/url_constants.h | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/chrome/common/url_constants.cc b/chrome/common/url_constants.cc index 3754dab..f5db717 100644 --- a/chrome/common/url_constants.cc +++ b/chrome/common/url_constants.cc @@ -18,10 +18,16 @@ const char kHttpsScheme[] = "https"; const char kJavaScriptScheme[] = "javascript"; const char kMailToScheme[] = "mailto"; const char kUserScriptScheme[] = "chrome-user-script"; +const char kViewCacheScheme[] = "view-cache"; const char kViewSourceScheme[] = "view-source"; const char kStandardSchemeSeparator[] = "://"; const char kAboutBlankURL[] = "about:blank"; +const char kAboutCacheURL[] = "about:cache"; +const char kAboutMemoryURL[] = "about:memory"; + +const char kChromeUIIPCURL[] = "chrome-ui://about/ipc"; +const char kChromeUINetworkURL[] = "chrome-ui://about/network"; } // namespace chrome diff --git a/chrome/common/url_constants.h b/chrome/common/url_constants.h index 21808ce..6761663 100644 --- a/chrome/common/url_constants.h +++ b/chrome/common/url_constants.h @@ -22,6 +22,7 @@ extern const char kHttpsScheme[]; extern const char kJavaScriptScheme[]; extern const char kMailToScheme[]; extern const char kUserScriptScheme[]; +extern const char kViewCacheScheme[]; extern const char kViewSourceScheme[]; // Used to separate a standard scheme and the hostname: "://". @@ -29,6 +30,11 @@ extern const char kStandardSchemeSeparator[]; // About URLs (including schmes). extern const char kAboutBlankURL[]; +extern const char kAboutCacheURL[]; +extern const char kAboutMemoryURL[]; + +extern const char kChromeUIIPCURL[]; +extern const char kChromeUINetworkURL[]; } // namespace chrome |