diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-19 18:33:48 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-19 18:33:48 +0000 |
| commit | 848cd05ed947f5939df4cd6028aad4e068484c23 (patch) | |
| tree | fda36e250d3d83fbcb58e57b950aba56f090c575 /chrome/common | |
| parent | b988fe4ded9067b2e5cb7e3a3937036ce2cb09c8 (diff) | |
| download | chromium_src-848cd05ed947f5939df4cd6028aad4e068484c23.zip chromium_src-848cd05ed947f5939df4cd6028aad4e068484c23.tar.gz chromium_src-848cd05ed947f5939df4cd6028aad4e068484c23.tar.bz2 | |
Changes the bookmark model to allow more than one bookmark to
reference the same url. Clicking the star button edits the most
recently added bookmark for the URL. Dragging a button/star always
does a move, otherwise drops on the bookmark bar create a new
bookmark.
Also changed the add page context menu for the bookmark bar to
remember where you invoked it from.
BUG=1173228 1678
Review URL: http://codereview.chromium.org/3203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2413 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_types.h | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/chrome/common/notification_types.h b/chrome/common/notification_types.h index e2a0352..50e3b5b 100644 --- a/chrome/common/notification_types.h +++ b/chrome/common/notification_types.h @@ -355,7 +355,7 @@ enum NotificationType { // No details are expected. NOTIFY_AUTH_SUPPLIED, - // History, bookmarks -------------------------------------------------------- + // History ------------------------------------------------------------------- // Sent when a history service is created on the main thread. This is sent // after history is created, but before it has finished loading. Use @@ -389,21 +389,23 @@ enum NotificationType { // the details is history::URLsDeletedDetails that lists the deleted URLs. NOTIFY_HISTORY_URLS_DELETED, - // This is sent when the "starred" button is clicked, toggling the - // starredness of a tab's current URL. The source is a Profile and the - // details is history::URLsStarredDetails that contains the list of URLs and - // whether they were starred or unstarred. + // Sent by history when the favicon of a URL changes. + // The source is the profile, and the details is + // history::FavIconChangeDetails (see history_notifications.h). + NOTIFY_FAVICON_CHANGED, + + // Bookmarks ----------------------------------------------------------------- + + // Sent when the starred state of a URL changes. A URL is starred if there is + // at least one bookmark for it. The source is a Profile and the details is + // history::URLsStarredDetails that contains the list of URLs and whether + // they were starred or unstarred. NOTIFY_URLS_STARRED, // Sent when the bookmark bar model finishes loading. This source is the // Profile, and the details aren't used. NOTIFY_BOOKMARK_MODEL_LOADED, - // Sent by history when the favicon of a URL changes. - // The source is the profile, and the details is - // history::FavIconChangeDetails (see history_notifications.h). - NOTIFY_FAVICON_CHANGED, - // Sent when the bookmark bubble is shown for a particular URL. The source // is the profile, the details the URL. NOTIFY_BOOKMARK_BUBBLE_SHOWN, |