Adding UMA for sync promo.

R=sail@chromium.org
BUG=97820
TEST=Either change the macros, check the codeflow, or add breakpoints to see if
UMA_* macros and other things are working (and it should also compile).


Review URL: http://codereview.chromium.org/8116024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104870 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 30 insertions, 4 deletions

diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h
index f1ae10b..443db17c 100644
--- a/chrome/common/extensions/extension_constants.h
+++ b/chrome/common/extensions/extension_constants.h
@@ -464,6 +464,26 @@ namespace extension_misc {
     UNLOAD_REASON_UPDATE,     // Extension is being updated to a newer version.
     UNLOAD_REASON_UNINSTALL,  // Extension is being uninstalled.
   };
+
+  // User actions on the sync promo (aka "Sign in to Chrome").
+  enum SyncPromoBuckets {
+    SYNC_PROMO_VIEWED,
+    SYNC_PROMO_LEARN_MORE_CLICKED,
+    SYNC_PROMO_ACCOUNT_HELP_CLICKED,
+    SYNC_PROMO_CREATE_ACCOUNT_CLICKED,
+    SYNC_PROMO_SKIP_CLICKED,
+    SYNC_PROMO_SIGN_IN_ATTEMPTED,
+    SYNC_PROMO_SIGNED_IN_SUCCESSFULLY,
+    SYNC_PROMO_ADVANCED_CLICKED,
+    SYNC_PROMO_ENCRYPTION_HELP_CLICKED,
+    SYNC_PROMO_CANCELLED_AFTER_SIGN_IN,
+    SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN,
+    SYNC_PROMO_CLOSED_TAB,
+    SYNC_PROMO_CLOSED_WINDOW,
+    SYNC_PROMO_BUCKET_BOUNDARY,
+    SYNC_PROMO_FIRST_VALID_JS_ACTION = SYNC_PROMO_LEARN_MORE_CLICKED,
+    SYNC_PROMO_LAST_VALID_JS_ACTION = SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN,
+  };
 } // extension_misc
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index af6c624..d7bed63 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -1112,9 +1112,6 @@ const char kShouldUseMinimalFirstRunBubble[] = "show-minimal-first-run-bubble";
 // Signal that we should show the welcome page when we launch Chrome.
 const char kShouldShowWelcomePage[] = "show-welcome-page";
 
-// Tracks the number of times that we have shown the sync promo at startup.
-const char kSyncPromoStartupCount[] = "sync-promo-startup-count";
-
 // String containing the last known Google URL.  We re-detect this on startup in
 // most cases, and use it to send traffic to the correct Google host or with the
 // correct Google domain/country code for whatever location the user is in.
@@ -1398,6 +1395,13 @@ const char kSyncUsingSecondaryPassphrase[] = "sync.using_secondary_passphrase";
 // String that identifies the user logged into sync and other google services.
 const char kGoogleServicesUsername[] = "google.services.username";
 
+// Tracks the number of times that we have shown the sync promo at startup.
+const char kSyncPromoStartupCount[] = "sync_promo.startup_count";
+
+// A counter to remember the number of times we've been to the sync promo page
+// (not at startup).
+const char kSyncPromoViewCount[] = "sync_promo.view_count";
+
 // Create web application shortcut dialog preferences.
 const char kWebAppCreateOnDesktop[] = "browser.web_app.create_on_desktop";
 const char kWebAppCreateInAppsMenu[] = "browser.web_app.create_in_apps_menu";
diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
index f0fb46c..56a1b7f 100644
--- a/chrome/common/pref_names.h
+++ b/chrome/common/pref_names.h
@@ -394,7 +394,6 @@ extern const char kShouldShowFirstRunBubble[];
 extern const char kShouldUseOEMFirstRunBubble[];
 extern const char kShouldUseMinimalFirstRunBubble[];
 extern const char kShouldShowWelcomePage[];
-extern const char kSyncPromoStartupCount[];
 
 extern const char kLastKnownGoogleURL[];
 extern const char kLastPromptedGoogleURL[];
@@ -507,6 +506,9 @@ extern const char kSyncUsingSecondaryPassphrase[];
 extern const char kSyncEncryptionBootstrapToken[];
 extern const char kSyncAcknowledgedSyncTypes[];
 
+extern const char kSyncPromoStartupCount[];
+extern const char kSyncPromoViewCount[];
+
 extern const char kWebAppCreateOnDesktop[];
 extern const char kWebAppCreateInAppsMenu[];
 extern const char kWebAppCreateInQuickLaunchBar[];