diff options
| author | pam@chromium.org <pam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-10 22:09:24 +0000 |
|---|---|---|
| committer | pam@chromium.org <pam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-10 22:09:24 +0000 |
| commit | ea59590d616a6a348e153024b77eb1e4f61a5eb6 (patch) | |
| tree | 01dd831bdc3952ed99883472b2a4581ad04c958f /chrome/common | |
| parent | bc389d78c9ec3c5f5f1cb416c3b83aefcf969a98 (diff) | |
| download | chromium_src-ea59590d616a6a348e153024b77eb1e4f61a5eb6.zip chromium_src-ea59590d616a6a348e153024b77eb1e4f61a5eb6.tar.gz chromium_src-ea59590d616a6a348e153024b77eb1e4f61a5eb6.tar.bz2 | |
Fix memory leak in ExtensionTest.LoadPageActionHelper unit test. The leak
was in the test only, not in the app code.
BUG=26216
TEST=covered by Linux valgrind (1) buildbot
Review URL: http://codereview.chromium.org/386002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31606 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/extensions/extension_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc index fb05f7f..6e1ad5e 100644 --- a/chrome/common/extensions/extension_unittest.cc +++ b/chrome/common/extensions/extension_unittest.cc @@ -302,8 +302,8 @@ TEST(ExtensionTest, LoadPageActionHelper) { DictionaryValue input; // First try with an empty dictionary. - ASSERT_TRUE(extension.LoadExtensionActionHelper( - &input, &error_msg) != NULL); + action.reset(extension.LoadExtensionActionHelper(&input, &error_msg)); + ASSERT_TRUE(action != NULL); ASSERT_STREQ("", error_msg.c_str()); error_msg = ""; |