diff options
| author | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-28 22:10:17 +0000 |
|---|---|---|
| committer | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-28 22:10:17 +0000 |
| commit | ecd9d87092866d04c00b5695ac56f0a026a6a2c8 (patch) | |
| tree | 8af05cf2b9c524db3d40a7007ed5ec137a820d12 /chrome/common | |
| parent | 7ea9cbb1f61ea1b6990011d076bc09c05b9e72e8 (diff) | |
| download | chromium_src-ecd9d87092866d04c00b5695ac56f0a026a6a2c8.zip chromium_src-ecd9d87092866d04c00b5695ac56f0a026a6a2c8.tar.gz chromium_src-ecd9d87092866d04c00b5695ac56f0a026a6a2c8.tar.bz2 | |
Make a step on refactoring navigation. The eventual plan is to have the NavigationController create and commit the new NavigationEntries (currently WebContents does a bunch of the details of this which is hard to understand and not easily testable).
This tries to consolidate the logic that I want to move to the NavigationController without actually moving it there yet. I removed all of the "PreCommit" functions in WebContents, since when the NavigationController does
all of the committing, there won't be a phase where the NavigationEntry exists but isn't committed.
Most of the logic could be moved to the PostCommit functions without any problem, which is an indication that the current design was busted anyway. I had to precompute some data and pass it to the *PostCommit function to work around some of the components that required old data. I had to change InfoBars around since it relied on having both the committed and uncommitted entries, but I think the new design is much better anyway.
BUG=1343593,1343146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1506 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_types.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/common/notification_types.h b/chrome/common/notification_types.h index 7bd9bb1..cff0655 100644 --- a/chrome/common/notification_types.h +++ b/chrome/common/notification_types.h @@ -43,6 +43,9 @@ enum NotificationType { // A new non-pending navigation entry has been created. This will correspond // to one NavigationController entry being created (in the case of new // navigations) or renavigated to (for back/forward navigations). + // + // The source will be the navigation controller doing the commit. The details + // will be NavigationController::LoadCommittedDetails. NOTIFY_NAV_ENTRY_COMMITTED, // Indicates that the NavigationController given in the Source has decreased |