diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-05 23:46:02 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-05 23:46:02 +0000 |
commit | 2858bbf9099f835325422009c5945e9b26a97d42 (patch) | |
tree | 4751ec07dc414566f15d9995386b73805facfca0 /chrome/common | |
parent | e22ddddb19c659dce909396cb2320979cbedc5d2 (diff) | |
download | chromium_src-2858bbf9099f835325422009c5945e9b26a97d42.zip chromium_src-2858bbf9099f835325422009c5945e9b26a97d42.tar.gz chromium_src-2858bbf9099f835325422009c5945e9b26a97d42.tar.bz2 |
FBTF: Continue fixing nits found by my automated source scanner.
(~1.3 megs off Debug linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3556013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r-- | chrome/common/desktop_notifications/active_notification_tracker.cc | 4 | ||||
-rw-r--r-- | chrome/common/desktop_notifications/active_notification_tracker.h | 3 | ||||
-rw-r--r-- | chrome/common/extensions/update_manifest.cc | 4 | ||||
-rw-r--r-- | chrome/common/extensions/update_manifest.h | 3 | ||||
-rw-r--r-- | chrome/common/pepper_plugin_registry.cc | 4 | ||||
-rw-r--r-- | chrome/common/pepper_plugin_registry.h | 3 | ||||
-rw-r--r-- | chrome/common/sqlite_compiled_statement.cc | 4 | ||||
-rw-r--r-- | chrome/common/sqlite_compiled_statement.h | 6 |
8 files changed, 26 insertions, 5 deletions
diff --git a/chrome/common/desktop_notifications/active_notification_tracker.cc b/chrome/common/desktop_notifications/active_notification_tracker.cc index 01f39dd..7bf619c 100644 --- a/chrome/common/desktop_notifications/active_notification_tracker.cc +++ b/chrome/common/desktop_notifications/active_notification_tracker.cc @@ -12,6 +12,10 @@ using WebKit::WebNotification; using WebKit::WebNotificationPermissionCallback; +ActiveNotificationTracker::ActiveNotificationTracker() {} + +ActiveNotificationTracker::~ActiveNotificationTracker() {} + bool ActiveNotificationTracker::GetId( const WebNotification& notification, int& id) { ReverseTable::iterator iter = reverse_notification_table_.find(notification); diff --git a/chrome/common/desktop_notifications/active_notification_tracker.h b/chrome/common/desktop_notifications/active_notification_tracker.h index 07f2d72..2fd8a6a 100644 --- a/chrome/common/desktop_notifications/active_notification_tracker.h +++ b/chrome/common/desktop_notifications/active_notification_tracker.h @@ -22,7 +22,8 @@ class WebNotificationPermissionCallback; // the main thread. class ActiveNotificationTracker { public: - ActiveNotificationTracker() {} + ActiveNotificationTracker(); + ~ActiveNotificationTracker(); // Methods for tracking active notification objects. int RegisterNotification(const WebKit::WebNotification& notification); diff --git a/chrome/common/extensions/update_manifest.cc b/chrome/common/extensions/update_manifest.cc index 0e2d271..45c4549 100644 --- a/chrome/common/extensions/update_manifest.cc +++ b/chrome/common/extensions/update_manifest.cc @@ -18,6 +18,10 @@ static const char* kExpectedGupdateProtocol = "2.0"; static const char* kExpectedGupdateXmlns = "http://www.google.com/update2/response"; +UpdateManifest::Results::Results() {} + +UpdateManifest::Results::~Results() {} + UpdateManifest::UpdateManifest() { results_.daystart_elapsed_seconds = kNoDaystart; } diff --git a/chrome/common/extensions/update_manifest.h b/chrome/common/extensions/update_manifest.h index 7c22d6f..16a4f01 100644 --- a/chrome/common/extensions/update_manifest.h +++ b/chrome/common/extensions/update_manifest.h @@ -45,6 +45,9 @@ class UpdateManifest { static const int kNoDaystart = -1; struct Results { + Results(); + ~Results(); + std::vector<Result> list; // This will be >= 0, or kNoDaystart if the <daystart> tag was not present. int daystart_elapsed_seconds; diff --git a/chrome/common/pepper_plugin_registry.cc b/chrome/common/pepper_plugin_registry.cc index cda5809..b6943af9a 100644 --- a/chrome/common/pepper_plugin_registry.cc +++ b/chrome/common/pepper_plugin_registry.cc @@ -18,6 +18,8 @@ PepperPluginInfo::PepperPluginInfo() : is_internal(false) { } +PepperPluginInfo::~PepperPluginInfo() {} + // static PepperPluginRegistry* PepperPluginRegistry::GetInstance() { static PepperPluginRegistry registry; @@ -168,6 +170,8 @@ pepper::PluginModule* PepperPluginRegistry::GetModule( return it->second; } +PepperPluginRegistry::~PepperPluginRegistry() {} + PepperPluginRegistry::PepperPluginRegistry() { InternalPluginInfoList internal_plugin_info; GetInternalPluginInfo(&internal_plugin_info); diff --git a/chrome/common/pepper_plugin_registry.h b/chrome/common/pepper_plugin_registry.h index 9b12f7e..2938729 100644 --- a/chrome/common/pepper_plugin_registry.h +++ b/chrome/common/pepper_plugin_registry.h @@ -15,6 +15,7 @@ struct PepperPluginInfo { PepperPluginInfo(); // Needed to initialize |is_internal|. + ~PepperPluginInfo(); bool is_internal; // Defaults to false (see constructor). FilePath path; // Internal plugins have "internal-[name]" as path. @@ -42,6 +43,8 @@ class PepperPluginRegistry { pepper::PluginModule* GetModule(const FilePath& path) const; + ~PepperPluginRegistry(); + private: static void GetPluginInfoFromSwitch(std::vector<PepperPluginInfo>* plugins); static void GetExtraPlugins(std::vector<PepperPluginInfo>* plugins); diff --git a/chrome/common/sqlite_compiled_statement.cc b/chrome/common/sqlite_compiled_statement.cc index 19b9e53..d5f063e 100644 --- a/chrome/common/sqlite_compiled_statement.cc +++ b/chrome/common/sqlite_compiled_statement.cc @@ -11,6 +11,10 @@ // SqliteStatementCache ------------------------------------------------------- +SqliteStatementCache::SqliteStatementCache() : db_(NULL) {} + +SqliteStatementCache::SqliteStatementCache(sqlite3* db) : db_(db) {} + SqliteStatementCache::~SqliteStatementCache() { STLDeleteContainerPairSecondPointers(statements_.begin(), statements_.end()); statements_.clear(); diff --git a/chrome/common/sqlite_compiled_statement.h b/chrome/common/sqlite_compiled_statement.h index edc60de..81f09a2 100644 --- a/chrome/common/sqlite_compiled_statement.h +++ b/chrome/common/sqlite_compiled_statement.h @@ -21,11 +21,9 @@ class SQLStatement; class SqliteStatementCache { public: // You must call set_db before anything else if you use this constructor. - SqliteStatementCache() : db_(NULL) { - } + SqliteStatementCache(); - explicit SqliteStatementCache(sqlite3* db) : db_(db) { - } + explicit SqliteStatementCache(sqlite3* db); // This object must be deleted before the sqlite connection it is associated // with. Otherwise, sqlite seems to keep the file open because there are open |