diff options
author | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-04 20:42:53 +0000 |
---|---|---|
committer | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-04 20:42:53 +0000 |
commit | 8fda0ab08a219c0d96e3d51d26479d10f386ee30 (patch) | |
tree | fc16acfbfebd0795629f7e4c87e0500258566cfc /chrome/common | |
parent | 38b8971cd5d5a9481d571d7bfca44a06566111d5 (diff) | |
download | chromium_src-8fda0ab08a219c0d96e3d51d26479d10f386ee30.zip chromium_src-8fda0ab08a219c0d96e3d51d26479d10f386ee30.tar.gz chromium_src-8fda0ab08a219c0d96e3d51d26479d10f386ee30.tar.bz2 |
Revert 80318 - Detach the PromoResourceService and WebResourceService from the Profile; have them store web resource data in local state instead.
We don't need multiple services for different Profiles; instead, there is a single service that captures data in local_state. The only preference stored in the Profile about the promo will be a bool indicating whether it's been closed or not, which will now be set outside the service.
Reviewers:
arv for general changes to PromoResourceService, & unittest.
erg for pulling the service out of the Profile and serving it up as a Singleton.
zmo for the changes I made to gpu_data_manager.
jstritar FYI, for changes to the PromoResourceService.
BUG=77155
TEST=promo resource service unittests.
Review URL: http://codereview.chromium.org/6736028
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6677140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80369 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r-- | chrome/common/pref_names.cc | 30 | ||||
-rw-r--r-- | chrome/common/pref_names.h | 2 |
2 files changed, 21 insertions, 11 deletions
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc index 252588e..cf08c3a 100644 --- a/chrome/common/pref_names.cc +++ b/chrome/common/pref_names.cc @@ -726,17 +726,6 @@ const char kMetricsInitialLogs[] = const char kMetricsOngoingLogs[] = "user_experience_metrics.ongoing_logs"; -// Whether promo should be shown to Dev builds, Beta and Dev, or all builds. -const char kNTPPromoBuild[] = "ntp.promo_build"; - -// Promo line from server. -const char kNTPPromoLine[] = "ntp.promo_line"; - -// Dates between which the NTP should show a promotional line downloaded -// from the promo server. -const char kNTPPromoStart[] = "ntp.promo_start"; -const char kNTPPromoEnd[] = "ntp.promo_end"; - // Where profile specific metrics are placed. const char kProfileMetrics[] = "user_experience_metrics.profiles"; @@ -1086,9 +1075,28 @@ const char kNTPPrefVersion[] = "ntp.pref_version"; const char kNTPCustomLogoStart[] = "ntp.alt_logo_start"; const char kNTPCustomLogoEnd[] = "ntp.alt_logo_end"; +// Whether promo should be shown to Dev builds, Beta and Dev, or all builds. +const char kNTPPromoBuild[] = "ntp.promo_build"; + // True if user has explicitly closed the promo line. const char kNTPPromoClosed[] = "ntp.promo_closed"; +// Users are randomly divided into 16 groups in order to slowly roll out +// special promos. +const char kNTPPromoGroup[] = "ntp.promo_group"; + +// Amount of time each promo group should be shown a promo that is being slowly +// rolled out, in hours. +const char kNTPPromoGroupTimeSlice[] = "ntp.promo_group_timeslice"; + +// Promo line from server. +const char kNTPPromoLine[] = "ntp.promo_line"; + +// Dates between which the NTP should show a promotional line downloaded +// from the promo server. +const char kNTPPromoStart[] = "ntp.promo_start"; +const char kNTPPromoEnd[] = "ntp.promo_end"; + // The most up-to-date GPU blacklist downloaded from the web, which replaces // the one that's installed with chrome. const char kGpuBlacklist[] = "gpu_blacklist"; diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h index 69577ea..acfd6cc 100644 --- a/chrome/common/pref_names.h +++ b/chrome/common/pref_names.h @@ -380,6 +380,8 @@ extern const char kNTPPromoStart[]; extern const char kNTPPromoEnd[]; extern const char kNTPPromoLine[]; extern const char kNTPPromoClosed[]; +extern const char kNTPPromoGroup[]; +extern const char kNTPPromoGroupTimeSlice[]; extern const char kNTPPromoBuild[]; extern const char kGpuBlacklist[]; |