Add support for constrained windows on os x, based on Avi's GTMWindowSheetController. Add carpet bombing dialog as first per-tab sheet.

Depends http://codereview.appspot.com/105064 .

The main issue with this patch is that GTMWindowSheetController doesn't provide an api to move sheets between windows, so this CL disables tab dragging for tabs with sheets, and fullscreen mode for windows with sheets. We can fix this later.

Other stuff that should be done at some point, but not now:

* Open/Save panels should be per-tab
* Need an ui test that goes to page, then page with sheet, then hit back, forward, reload.
* Bookmark sheets should not be sheets but in a separate window

BUG=14666
TEST=Go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , a per-window sheet should appear. Things to test with this dialog:

* Hitting cmd-q while a sheet is open in any tab should not quit but instead focus the sheet.

* Hitting cmd-w while a sheet is open in any tab should not close the window but instead focus the sheet.

* Dragging a tab with a sheet should move the window (and keep the tab visible), not detach the tab.

* Going fullscreen should be disabled for windows with open tabs.

* When a per-tab sheet is open in a non-active tab, it shouldn't steal the focus, i.e. going to the page above, then hitting cmd-t, and then hitting cmd-l should work.

* Closing a non-frontmost tab with a per-tab sheet shouldn't crash.

* Going to the url above and quickly opening a new tab, so that the sheet opens while its tab is not front-most should work (sheet should display only when you switch back to the tab with the sheet).

* Go to google.com, then to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html ,
  hit "backward" with open sheet, hit forward, focus location bar, hit enter. This shouldn't crash.

* Hitting escape should dismiss the sheet

* Hitting enter should confirm the sheet.

Review URL: http://codereview.chromium.org/159780

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23091 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 2 deletions

diff --git a/chrome/common/temp_scaffolding_stubs.cc b/chrome/common/temp_scaffolding_stubs.cc
index cf0f4b2..2906a95 100644
--- a/chrome/common/temp_scaffolding_stubs.cc
+++ b/chrome/common/temp_scaffolding_stubs.cc
@@ -245,7 +245,7 @@ void MemoryDetails::StartFetch() {
   NOTIMPLEMENTED();
 }
 
-#if defined(OS_MACOSX) || (defined(OS_LINUX) && defined(TOOLKIT_VIEWS))
+#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
 // This should prompt the user if she wants to allow more than one concurrent
 // download per tab. Until this is in place, always allow multiple downloads.
 class DownloadRequestDialogDelegateStub
@@ -253,7 +253,7 @@ class DownloadRequestDialogDelegateStub
  public:
   explicit DownloadRequestDialogDelegateStub(
     DownloadRequestManager::TabDownloadState* host)
-      : DownloadRequestDialogDelegate(host) { DoAccept(); }
+      : DownloadRequestDialogDelegate(host) { DoCancel(); }
 
   virtual void CloseWindow() {}
 };