diff options
| author | paulg@google.com <paulg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 02:03:20 +0000 |
|---|---|---|
| committer | paulg@google.com <paulg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 02:03:20 +0000 |
| commit | 05349986a0c968101b8925be496794b1f2bc40f5 (patch) | |
| tree | 7cb79c84d92e7e5910664e94979debb9980b3e3d /chrome/common | |
| parent | 3401b00e41731a8816d9aec9592b09efb4bf5eac (diff) | |
| download | chromium_src-05349986a0c968101b8925be496794b1f2bc40f5.zip chromium_src-05349986a0c968101b8925be496794b1f2bc40f5.tar.gz chromium_src-05349986a0c968101b8925be496794b1f2bc40f5.tar.bz2 | |
Fix a crash where the ResourceMessageFilter is deleted before a
SafeBrowsing check has completed. The problem occurs since the
SafeBrowsingResourceHandler is not deleted when its associated
URLRequest is cleaned up *and* a SafeBrowsing check is in progress.
When the check completes, the next resource handler in the chain
(the AsyncResourceHandler which caches a pointer the now deleted
ResourceMessageFilter) will crash.
This CL adds a notification for objects to know when the
ResourceMessageFilter is destroyed.
BUG=8544 (http://crbug.com)
Review URL: http://codereview.chromium.org/63036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13644 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_type.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/common/notification_type.h b/chrome/common/notification_type.h index e2b9da2..cae614d 100644 --- a/chrome/common/notification_type.h +++ b/chrome/common/notification_type.h @@ -157,6 +157,10 @@ class NotificationType { // both normal completion or via a cancel operation. DOWNLOAD_START, DOWNLOAD_STOP, + // Lets resource handlers and other interested observers know when the + // message filter is being deleted and can no longer be used. + RESOURCE_MESSAGE_FILTER_SHUTDOWN, + // Views ------------------------------------------------------------------- // Notification that a view was removed from a view hierarchy. The source |