diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-05 19:17:24 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-05 19:17:24 +0000 |
| commit | 81a34415cb55543b8f8db86ee6872cd70cd24445 (patch) | |
| tree | 6eaf45857f6a4a03d4f2ef55fe352b5bfe7bd233 /chrome/common | |
| parent | 52381d5530f56b905fb752e90e6ba24029eac199 (diff) | |
| download | chromium_src-81a34415cb55543b8f8db86ee6872cd70cd24445.zip chromium_src-81a34415cb55543b8f8db86ee6872cd70cd24445.tar.gz chromium_src-81a34415cb55543b8f8db86ee6872cd70cd24445.tar.bz2 | |
Refactor the render widget unittest so it can be reused to create a render view
unit test. Change the mock render thread to save all IPC messages it is asked to
send so that tests can verify that the correct ones were sent. There are some
new functions that support this checking.
Plumb the form state change notification through the render view so that we
will correctly update the form state to the browser.
Write two RenderView unit tests. One arbitrarily tests OnLoadAlternateHTMLText
which I used as a testcase for my testing framework. The other tests the above
form state change notification. I had to expose the timeout of this message
through the RenderView API so that the test can change it.
Review URL: http://codereview.chromium.org/16482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7549 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/ipc_message_utils.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/common/ipc_message_utils.h b/chrome/common/ipc_message_utils.h index 4234737..476d7f9 100644 --- a/chrome/common/ipc_message_utils.h +++ b/chrome/common/ipc_message_utils.h @@ -996,9 +996,11 @@ struct ParamTraits<webkit_glue::WebApplicationInfo> { // Generic message subclasses // Used for asynchronous messages. -template <class Param> +template <class ParamType> class MessageWithTuple : public Message { public: + typedef ParamType Param; + MessageWithTuple(int32 routing_id, uint16 type, const Param& p) : Message(routing_id, type, PRIORITY_NORMAL) { WriteParam(this, p); |