diff options
| author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 20:56:41 +0000 |
|---|---|---|
| committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 20:56:41 +0000 |
| commit | 912445b6db66140aecb3bc822075a6e9bb9d7e33 (patch) | |
| tree | 03494f511cbe131db3862fedd9e0158ae8e9ce9a /chrome/common | |
| parent | 8321a3750c190dc9eeaf75d1bfff9269e8b1846c (diff) | |
| download | chromium_src-912445b6db66140aecb3bc822075a6e9bb9d7e33.zip chromium_src-912445b6db66140aecb3bc822075a6e9bb9d7e33.tar.gz chromium_src-912445b6db66140aecb3bc822075a6e9bb9d7e33.tar.bz2 | |
Revert "POSIX: Don't allow onunload handlers to hang a renderer forever."
This reverts commit r15025. Calling exit() on another thread meant
V8's destructor functions got called while another thread was still in
V8.
I might not have a better plan, but it's making a mess of the valgrind
builders so I'm reverting for now with an eye to landing again next
week.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15095 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/ipc_channel_proxy.cc | 3 | ||||
| -rw-r--r-- | chrome/common/ipc_channel_proxy.h | 4 |
2 files changed, 0 insertions, 7 deletions
diff --git a/chrome/common/ipc_channel_proxy.cc b/chrome/common/ipc_channel_proxy.cc index c43f01f..47aa89b 100644 --- a/chrome/common/ipc_channel_proxy.cc +++ b/chrome/common/ipc_channel_proxy.cc @@ -81,9 +81,6 @@ void ChannelProxy::Context::OnChannelConnected(int32 peer_pid) { // Called on the IPC::Channel thread void ChannelProxy::Context::OnChannelError() { - for (size_t i = 0; i < filters_.size(); ++i) - filters_[i]->OnChannelError(); - // See above comment about using listener_message_loop_ here. listener_message_loop_->PostTask(FROM_HERE, NewRunnableMethod( this, &Context::OnDispatchError)); diff --git a/chrome/common/ipc_channel_proxy.h b/chrome/common/ipc_channel_proxy.h index 42cb865..2263ea6 100644 --- a/chrome/common/ipc_channel_proxy.h +++ b/chrome/common/ipc_channel_proxy.h @@ -64,10 +64,6 @@ class ChannelProxy : public Message::Sender { // have received the internal Hello message from the peer. virtual void OnChannelConnected(int32 peer_pid) {} - // Called when there is an error on the channel, typically that the channel - // has been closed. - virtual void OnChannelError() {} - // Called to inform the filter that the IPC channel will be destroyed. // OnFilterRemoved is called immediately after this. virtual void OnChannelClosing() {} |