diff options
| author | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-12 16:11:09 +0000 |
|---|---|---|
| committer | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-12 16:11:09 +0000 |
| commit | b6e09acf8ced26198871626c76bb5a3741cc51f1 (patch) | |
| tree | a4029d45393a1c34ba1b88d67c052512ad16c7eb /chrome/common | |
| parent | 2526315929de99fa5762583621fb52b626a62ef9 (diff) | |
| download | chromium_src-b6e09acf8ced26198871626c76bb5a3741cc51f1.zip chromium_src-b6e09acf8ced26198871626c76bb5a3741cc51f1.tar.gz chromium_src-b6e09acf8ced26198871626c76bb5a3741cc51f1.tar.bz2 | |
Move RenderViewHost management out of WebContents into a new
RenderViewHostManager object.
The goal for this patch is to change no logic or APIs, just move the code. So
there are some not very clean callback functions and no new unit tests for this
file (although is is still covered by the same WebContents unit tests). This
should make the actual cleanup in a later pass much easier to follow.
I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@716 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_types.h | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/chrome/common/notification_types.h b/chrome/common/notification_types.h index 42c1804..1feae5f 100644 --- a/chrome/common/notification_types.h +++ b/chrome/common/notification_types.h @@ -364,8 +364,9 @@ enum NotificationType { NOTIFY_BOOKMARK_BAR_VISIBILITY_PREF_CHANGED, // This is sent when an interstitial page showing in a WebContents is closed - // (as the result of a navigation to another page). The source is the - // WebContents the interstitial page is in. + // (as the result of a navigation to another page). The source is the + // NavigationController associated with the tab. + // // Note that you should not initiate a navigation as part of the processing of // this notification, since this notification may be triggered as part of the // destruction of the tab contents (the navigation controller would reuse @@ -401,9 +402,9 @@ enum NotificationType { NOTIFY_PREF_CHANGED, // This is sent to notify that the RenderViewHost displayed in a WebContents - // has changed. Source is the WebContents for which the change happened, - // details is the previous RenderViewHost (can be NULL when the first - // RenderViewHost is set). + // has changed. Source is the NavigationController for which the change + // happened, and details is RenderViewHostSwitchedDetails + // (see render_view_host_manager.h). NOTIFY_RENDER_VIEW_HOST_CHANGED, // This notification is sent when a TabContents is being hidden, e.g. due to |