diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-13 22:42:47 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-13 22:42:47 +0000 |
| commit | cbab76d1c74c93837bc76298d1a2e43646154194 (patch) | |
| tree | 7f1bdcd891e670b67eeac2993730c580698048eb /chrome/common | |
| parent | 3c1e4d080a8e69fb973638d1360d4d5dd0d2e4d5 (diff) | |
| download | chromium_src-cbab76d1c74c93837bc76298d1a2e43646154194.zip chromium_src-cbab76d1c74c93837bc76298d1a2e43646154194.tar.gz chromium_src-cbab76d1c74c93837bc76298d1a2e43646154194.tar.bz2 | |
This is the first pass at refactoring the interstitial page.
The SSL and malware blocking pages were doing similar things in 2 different classes.
There is now a base class called InterstitialPage that contains the common logic.
As part of that refactoring, the safe browsing was changed so that the SafeBrowsingBlockingPage is only used from the UI thread.
This CL also adds transient entries to the navigation controller: that type of entry gets deleted as soon as a navigation occurs. It is used by interstitial that need to create such a temporary entry while they show.
BUG=3013
TEST=Run the unit tests and ui tests.
Review URL: http://codereview.chromium.org/6311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3324 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_types.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/chrome/common/notification_types.h b/chrome/common/notification_types.h index f6b1ad7..4340c9b 100644 --- a/chrome/common/notification_types.h +++ b/chrome/common/notification_types.h @@ -134,15 +134,6 @@ enum NotificationType { NOTIFY_DOWNLOAD_START, NOTIFY_DOWNLOAD_STOP, - // This is sent when an interstitial page showing in a WebContents is closed - // (as the result of a navigation to another page). The source is the - // WebContents the interstitial page is in. - // Note that you should not initiate a navigation as part of the processing of - // this notification, since this notification may be triggered as part of the - // destruction of the tab contents (the navigation controller would reuse - // the tab contents right before it would be destroyed). - NOTIFY_INTERSTITIAL_PAGE_CLOSED, - // Views --------------------------------------------------------------------- // Notification that a view was removed from a view hierarchy. The source is |