Remove more definitions from header files.

This patch only concerns itself with places where we have more than 100 copies of methods being generated. (For example, the destructor and other random methods in FilePath weren't being inlined, leading to several hundred copies being generated.)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3039001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52694 0039d316-1c4b-4281-b951-d872f2087c98

6 files changed, 45 insertions, 7 deletions

diff --git a/chrome/common/notification_details.cc b/chrome/common/notification_details.cc
new file mode 100644
index 0000000..4455faa
--- /dev/null
+++ b/chrome/common/notification_details.cc
@@ -0,0 +1,18 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/notification_details.h"
+
+NotificationDetails::NotificationDetails() : ptr_(NULL) {
+}
+
+NotificationDetails::NotificationDetails(const NotificationDetails& other)
+    : ptr_(other.ptr_) {
+}
+
+NotificationDetails::NotificationDetails(const void* ptr) : ptr_(ptr) {
+}
+
+NotificationDetails::~NotificationDetails() {
+}
diff --git a/chrome/common/notification_details.h b/chrome/common/notification_details.h
index 2c914d7..92c1906 100644
--- a/chrome/common/notification_details.h
+++ b/chrome/common/notification_details.h
@@ -15,9 +15,9 @@
 // NotificationService::NoDetails().
 class NotificationDetails {
  public:
-  NotificationDetails() : ptr_(NULL) {}
-  NotificationDetails(const NotificationDetails& other) : ptr_(other.ptr_) {}
-  ~NotificationDetails() {}
+  NotificationDetails();
+  NotificationDetails(const NotificationDetails& other);
+  ~NotificationDetails();
 
   // NotificationDetails can be used as the index for a map; this method
   // returns the pointer to the current details as an identifier, for use as a
@@ -33,7 +33,7 @@ class NotificationDetails {
   }
 
  protected:
-  explicit NotificationDetails(const void* ptr) : ptr_(ptr) {}
+  explicit NotificationDetails(const void* ptr);
 
   // Declaring this const allows Details<T> to be used with both T = Foo and
   // T = const Foo.
diff --git a/chrome/common/notification_observer.h b/chrome/common/notification_observer.h
index b8c9842..8ad4d4a 100644
--- a/chrome/common/notification_observer.h
+++ b/chrome/common/notification_observer.h
@@ -13,6 +13,7 @@ class NotificationType;
 // notification is posted to the notification service, Observe is called.
 class NotificationObserver {
  public:
+  NotificationObserver();
   virtual ~NotificationObserver();
 
   virtual void Observe(NotificationType type,
diff --git a/chrome/common/notification_service.cc b/chrome/common/notification_service.cc
index 5d6378f..e127ccf 100644
--- a/chrome/common/notification_service.cc
+++ b/chrome/common/notification_service.cc
@@ -147,4 +147,6 @@ NotificationService::~NotificationService() {
   }
 }
 
+NotificationObserver::NotificationObserver() {}
+
 NotificationObserver::~NotificationObserver() {}
diff --git a/chrome/common/notification_source.cc b/chrome/common/notification_source.cc
new file mode 100644
index 0000000..e0f5ca0
--- /dev/null
+++ b/chrome/common/notification_source.cc
@@ -0,0 +1,17 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/notification_source.h"
+
+NotificationSource::NotificationSource(const NotificationSource& other)
+    : ptr_(other.ptr_) {
+}
+
+NotificationSource::NotificationSource(const void* ptr) : ptr_(ptr) {
+}
+
+NotificationSource::~NotificationSource() {
+}
+
+
diff --git a/chrome/common/notification_source.h b/chrome/common/notification_source.h
index 98b9f66..1813c2e 100644
--- a/chrome/common/notification_source.h
+++ b/chrome/common/notification_source.h
@@ -15,8 +15,8 @@
 // NotificationService::AllSources().
 class NotificationSource {
  public:
-  NotificationSource(const NotificationSource& other) : ptr_(other.ptr_) { }
-  ~NotificationSource() {}
+  NotificationSource(const NotificationSource& other);
+  ~NotificationSource();
 
   // NotificationSource can be used as the index for a map; this method
   // returns the pointer to the current source as an identifier, for use as a
@@ -31,7 +31,7 @@ class NotificationSource {
   }
 
  protected:
-  explicit NotificationSource(const void* ptr) : ptr_(ptr) {}
+  explicit NotificationSource(const void* ptr);
 
   // Declaring this const allows Source<T> to be used with both T = Foo and
   // T = const Foo.