diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-23 02:26:16 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-23 02:26:16 +0000 |
| commit | d0cc9fb540e7d11f8b154d513bf0a1c75460245c (patch) | |
| tree | 961c4d80f8628220b8798c67efb12a37070fb960 /chrome/common | |
| parent | 48bdfbf85c790ee91ec8f31242aaec1164273221 (diff) | |
| download | chromium_src-d0cc9fb540e7d11f8b154d513bf0a1c75460245c.zip chromium_src-d0cc9fb540e7d11f8b154d513bf0a1c75460245c.tar.gz chromium_src-d0cc9fb540e7d11f8b154d513bf0a1c75460245c.tar.bz2 | |
Rejiggers the keyword editor so that the UI is independent of the model rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19003 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/temp_scaffolding_stubs.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/chrome/common/temp_scaffolding_stubs.cc b/chrome/common/temp_scaffolding_stubs.cc index 8b4b46a..146e956 100644 --- a/chrome/common/temp_scaffolding_stubs.cc +++ b/chrome/common/temp_scaffolding_stubs.cc @@ -19,7 +19,6 @@ #include "chrome/browser/memory_details.h" #include "chrome/browser/options_window.h" #include "chrome/browser/rlz/rlz.h" -#include "chrome/browser/search_engines/edit_keyword_controller_base.h" #include "chrome/browser/shell_integration.h" #include "chrome/browser/tab_contents/infobar_delegate.h" #include "chrome/common/process_watcher.h" @@ -315,13 +314,6 @@ void ShowOptionsWindow(OptionsPage page, Profile* profile) { NOTIMPLEMENTED(); } - -void EditKeywordControllerBase::Create(gfx::NativeWindow parent_window, - const TemplateURL* template_url, - Delegate* delegate, - Profile* profile) { - NOTIMPLEMENTED(); -} #endif #if defined(OS_MACOSX) |