Implement temporary First Run Dialog on OS X

We use a modal dialog with a single checkbox on OS X.

We use the OSX defaults system since we want something quick and reliable.  The
dialog is displayed at a very early stage in Chrome startup (Before any
subsystems start relying on the stats variable).  This means there are a few
quirks in displaying the UI.

A change was also needed to our event handling code since when the dialog is
shown we spin an event loop at a very early stage in the process lifetime.

Changed default value for stats to false and updated unit tests to reflect that.

Also some misc. minor cleanup.

BUG=11971,12046

Review URL: http://codereview.chromium.org/115608

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16669 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 4 deletions

diff --git a/chrome/common/temp_scaffolding_stubs.cc b/chrome/common/temp_scaffolding_stubs.cc
index 938398a..63f27da 100644
--- a/chrome/common/temp_scaffolding_stubs.cc
+++ b/chrome/common/temp_scaffolding_stubs.cc
@@ -135,12 +135,18 @@ bool ShellIntegration::IsDefaultBrowser() {
 
 //--------------------------------------------------------------------------
 
+#if defined(OS_LINUX)
 // static
 bool FirstRun::IsChromeFirstRun() {
   // http://code.google.com/p/chromium/issues/detail?id=11971
   return false;
 }
 
+void OpenFirstRunDialog(Profile* profile, ProcessSingleton* process_singleton) {
+  NOTIMPLEMENTED();
+}
+#endif  // defined(OS_LINUX)
+
 // static
 bool FirstRun::ProcessMasterPreferences(const FilePath& user_data_dir,
                                         const FilePath& master_prefs_path,
@@ -174,10 +180,6 @@ bool Upgrade::SwapNewChromeExeIfPresent() {
   return true;
 }
 
-void OpenFirstRunDialog(Profile* profile, ProcessSingleton* process_singleton) {
-  NOTIMPLEMENTED();
-}
-
 //--------------------------------------------------------------------------
 
 void InstallJankometer(const CommandLine&) {