summaryrefslogtreecommitdiffstats
path: root/chrome/common
diff options
context:
space:
mode:
authormad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-12 14:46:17 +0000
committermad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-12 14:46:17 +0000
commitf21c613a0ab52b707f8a2effacda74c77f4448ea (patch)
tree09051d286db764a71b97bc01f35765e607b4d20f /chrome/common
parent822cfc93fe52974b904b7f184c5448dee5d281c5 (diff)
downloadchromium_src-f21c613a0ab52b707f8a2effacda74c77f4448ea.zip
chromium_src-f21c613a0ab52b707f8a2effacda74c77f4448ea.tar.gz
chromium_src-f21c613a0ab52b707f8a2effacda74c77f4448ea.tar.bz2
This is an attempt at finding the reason for the page_cycler slowness caused by
the new resize corner. Local experiment led me to believe that it is WebKit that is slower when we specify a resize corner area. To validate this hypothesis, I always return an empty rect to WebKit, but I still compute and push the rect to the render widget and I also draw the bitmap even if this will cause it to be drawn on top of the scroll bars when there is only one. TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9654 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r--chrome/common/render_messages_internal.h8
-rw-r--r--chrome/common/slide_animation.h2
-rw-r--r--chrome/common/temp_scaffolding_stubs.h4
3 files changed, 10 insertions, 4 deletions
diff --git a/chrome/common/render_messages_internal.h b/chrome/common/render_messages_internal.h
index 76e53c4..f61b122 100644
--- a/chrome/common/render_messages_internal.h
+++ b/chrome/common/render_messages_internal.h
@@ -70,9 +70,11 @@ IPC_BEGIN_MESSAGES(View)
// Tells the render view to change its size. A ViewHostMsg_PaintRect message
// is generated in response provided new_size is not empty and not equal to
// the view's current size. The generated ViewHostMsg_PaintRect message will
- // have the IS_RESIZE_ACK flag set.
- IPC_MESSAGE_ROUTED1(ViewMsg_Resize,
- gfx::Size /* new_size */)
+ // have the IS_RESIZE_ACK flag set. It also receives the resizer rect so that
+ // we don't have to fetch it every time WebKit asks for it.
+ IPC_MESSAGE_ROUTED2(ViewMsg_Resize,
+ gfx::Size /* new_size */,
+ gfx::Rect /* resizer_rect */)
// Sent to inform the view that it was hidden. This allows it to reduce its
// resource utilization.
diff --git a/chrome/common/slide_animation.h b/chrome/common/slide_animation.h
index f690e48..d998e6c 100644
--- a/chrome/common/slide_animation.h
+++ b/chrome/common/slide_animation.h
@@ -73,7 +73,7 @@ class SlideAnimation : public Animation {
void SetTweenType(TweenType tween_type) { tween_type_ = tween_type; }
double GetCurrentValue() const { return value_current_; }
- bool IsShowing() { return showing_; }
+ bool IsShowing() const { return showing_; }
private:
// Overridden from Animation.
diff --git a/chrome/common/temp_scaffolding_stubs.h b/chrome/common/temp_scaffolding_stubs.h
index 428acdd..1f17cc9 100644
--- a/chrome/common/temp_scaffolding_stubs.h
+++ b/chrome/common/temp_scaffolding_stubs.h
@@ -596,6 +596,10 @@ class TabContentsDelegate {
NOTIMPLEMENTED();
return true;
}
+ virtual gfx::Rect GetRootWindowResizerRect() const {
+ return gfx::Rect();
+ }
+
virtual bool IsExternalTabContainer() {
NOTIMPLEMENTED();
return false;