summaryrefslogtreecommitdiffstats
path: root/chrome/common
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-09 19:53:54 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-09 19:53:54 +0000
commit5d02724d02cd3e97209701d1aac8445a0ae7394e (patch)
tree7ebc5d64100c6e1f9e8cff8af6502425f0de2199 /chrome/common
parentfd9326f3e68b46614e31a524754ba64c9a1d179a (diff)
downloadchromium_src-5d02724d02cd3e97209701d1aac8445a0ae7394e.zip
chromium_src-5d02724d02cd3e97209701d1aac8445a0ae7394e.tar.gz
chromium_src-5d02724d02cd3e97209701d1aac8445a0ae7394e.tar.bz2
By changing how we #ifdef, we get a bunch more l10n functions.
Review URL: http://codereview.chromium.org/20171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9405 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r--chrome/common/l10n_util.cc9
-rw-r--r--chrome/common/temp_scaffolding_stubs.cc28
2 files changed, 6 insertions, 31 deletions
diff --git a/chrome/common/l10n_util.cc b/chrome/common/l10n_util.cc
index 562c205..1aeea0a 100644
--- a/chrome/common/l10n_util.cc
+++ b/chrome/common/l10n_util.cc
@@ -328,18 +328,22 @@ std::wstring GetString(int message_id) {
#endif
}
-#if defined(OS_WIN)
-// TODO(port): re-enable.
static std::wstring GetStringF(int message_id,
const std::wstring& a,
const std::wstring& b,
const std::wstring& c,
const std::wstring& d,
std::vector<size_t>* offsets) {
+#if defined(OS_WIN)
+// TODO(port): re-enable.
const std::wstring& format_string = GetString(message_id);
std::wstring formatted = ReplaceStringPlaceholders(format_string, a, b, c,
d, offsets);
return formatted;
+#else
+ NOTIMPLEMENTED();
+ return L"GetStringF NOTIMPLEMENTED";
+#endif // defined(OS_WIN)
}
std::wstring GetStringF(int message_id,
@@ -387,7 +391,6 @@ std::wstring GetStringF(int message_id, int a) {
std::wstring GetStringF(int message_id, int64 a) {
return GetStringF(message_id, Int64ToWString(a));
}
-#endif // defined(OS_WIN)
std::wstring TruncateString(const std::wstring& string, size_t length) {
if (string.size() <= length)
diff --git a/chrome/common/temp_scaffolding_stubs.cc b/chrome/common/temp_scaffolding_stubs.cc
index 197a645..bdee164 100644
--- a/chrome/common/temp_scaffolding_stubs.cc
+++ b/chrome/common/temp_scaffolding_stubs.cc
@@ -350,34 +350,6 @@ void ProcessWatcher::EnsureProcessTerminated(int) {
//--------------------------------------------------------------------------
-
-namespace l10n_util {
-
-std::wstring GetStringF(int message_id,
- const std::wstring& a) {
- NOTIMPLEMENTED();
- return L"";
-}
-
-std::wstring GetStringF(int message_id,
- const std::wstring& a,
- const std::wstring& b,
- std::vector<size_t>* offsets) {
- NOTIMPLEMENTED();
- return L"";
-}
-
-std::wstring GetStringF(int id,
- const std::wstring& a,
- const std::wstring& b,
- const std::wstring& c) {
- NOTIMPLEMENTED();
- return L"";
-}
-
-} // l10n_util
-
-//--------------------------------------------------------------------------
namespace webkit_glue {
bool IsDefaultPluginEnabled() {