diff options
| author | twiz@google.com <twiz@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 17:20:57 +0000 |
|---|---|---|
| committer | twiz@google.com <twiz@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 17:20:57 +0000 |
| commit | ccb686dd5e4c4e1b60109f7110badd78f8e76300 (patch) | |
| tree | 4f554d1fedbec8a577b051e6da8364e975233dd0 /chrome/common | |
| parent | 9fa8af659705465662679b7663aa501b5cdb0861 (diff) | |
| download | chromium_src-ccb686dd5e4c4e1b60109f7110badd78f8e76300.zip chromium_src-ccb686dd5e4c4e1b60109f7110badd78f8e76300.tar.gz chromium_src-ccb686dd5e4c4e1b60109f7110badd78f8e76300.tar.bz2 | |
A very basic fix that prevents experimental popups from living longer than the ExtensionFunctionDispatcher/RenderViewHost that launched the popup. This is a problem, for example, when Chrome is closed while a popup is still displayed.
I also removed the code that delayed sending the onClosed popup notification. I modified the ExtensionPopup::Obeserver interface to add methods for about-to-close, and fully-closed notifications.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/2092020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48841 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/notification_type.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/common/notification_type.h b/chrome/common/notification_type.h index f5a52e7..dd16e38 100644 --- a/chrome/common/notification_type.h +++ b/chrome/common/notification_type.h @@ -427,6 +427,14 @@ class NotificationType { // Sent from ~RenderViewHost. The source is the TabContents. RENDER_VIEW_HOST_DELETED, + // Sent from RenderViewHost::ClosePage. The hosted RenderView has + // processed the onbeforeunload handler and is about to be sent a + // ViewMsg_ClosePage message to complete the tear-down process. The source + // is the RenderViewHost sending the message, and no details are provided. + // Note: This message is not sent in response to RenderView closure + // initiated by window.close(). + RENDER_VIEW_HOST_WILL_CLOSE_RENDER_VIEW, + // Indicates a RenderWidgetHost has been hidden or restored. The source is // the RWH whose visibility changed, the details is a bool set to true if // the new state is "visible." |