summaryrefslogtreecommitdiffstats
path: root/chrome/common
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-28 06:52:35 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-28 06:52:35 +0000
commit329581b6dbfa4ad0ca1013d0407e202b8dffed77 (patch)
tree8a6832ac64e99760cb07b74a08896f7a41def051 /chrome/common
parent6faa0e0d23ca6fc27ae603063ce23eb018a670cd (diff)
downloadchromium_src-329581b6dbfa4ad0ca1013d0407e202b8dffed77.zip
chromium_src-329581b6dbfa4ad0ca1013d0407e202b8dffed77.tar.gz
chromium_src-329581b6dbfa4ad0ca1013d0407e202b8dffed77.tar.bz2
Synchronously update the loading state when a load starts so that the UI will
be more responsive and the loading state won't be out-of-sync with anything else. This also removes the synchronous update to the throbber when we load a URL because this happens before the loda actually starts, giving a flash of the default favicon. The load start call made by RenderViewHost will cover this case after the load actually starts. BUG=11051 Review URL: http://codereview.chromium.org/100033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14718 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r--chrome/common/render_messages_internal.h13
1 files changed, 8 insertions, 5 deletions
diff --git a/chrome/common/render_messages_internal.h b/chrome/common/render_messages_internal.h
index 478bed6..41f7a6b 100644
--- a/chrome/common/render_messages_internal.h
+++ b/chrome/common/render_messages_internal.h
@@ -667,11 +667,14 @@ IPC_BEGIN_MESSAGES(ViewHost)
// action (e.g. when the user is hovering over a link).
IPC_MESSAGE_ROUTED2(ViewHostMsg_UpdateTargetURL, int32, GURL)
- // Sent when the renderer is loading a frame
- IPC_MESSAGE_ROUTED1(ViewHostMsg_DidStartLoading, int32)
-
- // Sent when the renderer is done loading a frame
- IPC_MESSAGE_ROUTED1(ViewHostMsg_DidStopLoading, int32)
+ // Sent when the renderer starts loading the page. This corresponds to
+ // WebKit's notion of the throbber starting. Note that sometimes you may get
+ // duplicates of these during a single load.
+ IPC_MESSAGE_ROUTED0(ViewHostMsg_DidStartLoading)
+
+ // Sent when the renderer is done loading a page. This corresponds to WebKit's
+ // noption of the throbber stopping.
+ IPC_MESSAGE_ROUTED0(ViewHostMsg_DidStopLoading)
// Sent when the renderer loads a resource from its memory cache.
// The security info is non empty if the resource was originally loaded over