diff options
| author | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-11 03:39:04 +0000 |
|---|---|---|
| committer | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-11 03:39:04 +0000 |
| commit | 9174af4ea0610a8c7e5b9a453d8c13c7d3ce9c37 (patch) | |
| tree | 2ed34b54b220a192275df4430d3739c3a8afc540 /chrome/installer/setup/chrome_frame_ready_mode.cc | |
| parent | 5dc51db8c43f41e6733695644a66017cf043673a (diff) | |
| download | chromium_src-9174af4ea0610a8c7e5b9a453d8c13c7d3ce9c37.zip chromium_src-9174af4ea0610a8c7e5b9a453d8c13c7d3ce9c37.tar.gz chromium_src-9174af4ea0610a8c7e5b9a453d8c13c7d3ce9c37.tar.bz2 | |
C++ reability review for gab.
Added class ScopedTokenPrivilege in setup_util.[h|cc] to allow elevation of a process' privilege in the current scope while making sure we don't keep the privilege later (as these powerful privileges should be held for as little time as possible). This class is used in uninstall.cc and tested in setup_util_unittest.cc; I left the other files around for you to understand where this all hooks up.
Original review: https://chromiumcodereview.appspot.com/10810021/
I added an illegal (no space after //) comment to each file for them to be picked up. I will remove at the end (and the CQ will also make sure I do as this currently fails presubmit checks).
BUG=146850 (taking on this team refactoring task as part of this readability review).
Review URL: https://chromiumcodereview.appspot.com/10912096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155941 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/setup/chrome_frame_ready_mode.cc')
| -rw-r--r-- | chrome/installer/setup/chrome_frame_ready_mode.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/installer/setup/chrome_frame_ready_mode.cc b/chrome/installer/setup/chrome_frame_ready_mode.cc index b16e5a9..fb6ed36 100644 --- a/chrome/installer/setup/chrome_frame_ready_mode.cc +++ b/chrome/installer/setup/chrome_frame_ready_mode.cc @@ -94,10 +94,10 @@ InstallStatus ChromeFrameReadyModeOptIn( // This creates the uninstallation entry for GCF. AddUninstallShortcutWorkItems(opt_in_state, cf_state->GetSetupPath(), - cf_state->version(), item_list.get(), *cf); + cf_state->version(), *cf, item_list.get()); // This updates the Chrome uninstallation entries. AddUninstallShortcutWorkItems(opt_in_state, chrome_state->GetSetupPath(), - chrome_state->version(), item_list.get(), *chrome); + chrome_state->version(), *chrome, item_list.get()); // Add a work item to delete the ChromeFrameReadyMode registry value. HKEY root = opt_in_state.root_key(); |