diff options
| author | vabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-05 15:52:31 +0000 |
|---|---|---|
| committer | vabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-05 15:52:31 +0000 |
| commit | b2118283fc219e98f61ae159d4701c79701f9e12 (patch) | |
| tree | 70686b26d3f1e0c0a9c3a652d9d47c73b786b70c /chrome/installer/setup | |
| parent | 1f3d48e1f5072a7f0abb2719272d07332b6e525b (diff) | |
| download | chromium_src-b2118283fc219e98f61ae159d4701c79701f9e12.zip chromium_src-b2118283fc219e98f61ae159d4701c79701f9e12.tar.gz chromium_src-b2118283fc219e98f61ae159d4701c79701f9e12.tar.bz2 | |
Fix pre-allocation in WebRequestConditionAttributeResourceType::Create
In WebRequestConditionAttributeResourceType::Create, the vector of types was created via the "resize" constructor to the desired final size, but then items were added again using push_back. The added items were never read, and the default 0 values were used on their place.
This CL changes the implicit "resize" to an explicit "reserve", and also contains a minor fix in the unit tests, as well as a modification of the tests to catch this kind of error in the future.
BUG=179505
Review URL: https://chromiumcodereview.appspot.com/12429005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186183 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/setup')
0 files changed, 0 insertions, 0 deletions