diff options
| author | kuchhal@chromium.org <kuchhal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-03 17:46:05 +0000 |
|---|---|---|
| committer | kuchhal@chromium.org <kuchhal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-03 17:46:05 +0000 |
| commit | 6752d476fbb54c3dd00343c7b194c23620c3d1e5 (patch) | |
| tree | 77afb9a9f6a819e509f0a223f3b1e77012b9d47b /chrome/installer/util/browser_distribution.h | |
| parent | bf0791a666425e2e61400953fa538ed1d2b2edf8 (diff) | |
| download | chromium_src-6752d476fbb54c3dd00343c7b194c23620c3d1e5.zip chromium_src-6752d476fbb54c3dd00343c7b194c23620c3d1e5.tar.gz chromium_src-6752d476fbb54c3dd00343c7b194c23620c3d1e5.tar.bz2 | |
Refactoring of master preferences parsing before adding a new preference.
Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer.
No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again.
BUG=12701
TEST=Make sure all the distribution preferences still work as before.
Review URL: http://codereview.chromium.org/159539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22284 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util/browser_distribution.h')
| -rw-r--r-- | chrome/installer/util/browser_distribution.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h index 26f9b3b..452b8a2 100644 --- a/chrome/installer/util/browser_distribution.h +++ b/chrome/installer/util/browser_distribution.h @@ -58,7 +58,7 @@ class BrowserDistribution { // sets the wheels in motion or in simple cases does the experiment itself. virtual void LaunchUserExperiment(installer_util::InstallStatus status, const installer::Version& version, - bool system_install, int options); + bool system_install); // The user has qualified for the inactive user toast experiment and this // function just performs it. |