diff options
| author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-27 20:13:23 +0000 |
|---|---|---|
| committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-27 20:13:23 +0000 |
| commit | c12ecab6d48f359d79312aaae5f535b0f26f8445 (patch) | |
| tree | f24c364ea1906bb414d10888ff920feeaa024679 /chrome/installer/util/html_dialog.h | |
| parent | 28a5e7b166ea0eafa36d7626ad6767a365a7a332 (diff) | |
| download | chromium_src-c12ecab6d48f359d79312aaae5f535b0f26f8445.zip chromium_src-c12ecab6d48f359d79312aaae5f535b0f26f8445.tar.gz chromium_src-c12ecab6d48f359d79312aaae5f535b0f26f8445.tar.bz2 | |
Add undeclared virtual destructors part 2
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util/html_dialog.h')
| -rw-r--r-- | chrome/installer/util/html_dialog.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/installer/util/html_dialog.h b/chrome/installer/util/html_dialog.h index 325d978..80edbba 100644 --- a/chrome/installer/util/html_dialog.h +++ b/chrome/installer/util/html_dialog.h @@ -39,8 +39,13 @@ class HTMLDialog { // The native window has been created and is about to be visible. Use it // to customize the native |window| appearance. virtual void OnBeforeDisplay(void* window) = 0; + + protected: + virtual ~CustomizationCallback() {} }; + virtual ~HTMLDialog() {} + // Shows the HTML in a modal dialog. The buttons and other UI are also done // in HTML so each native implementation needs to map the user action into // one of the 6 possible results of DialogResult. Important, call this @@ -51,7 +56,6 @@ class HTMLDialog { // If the result of ShowModal() was EXTRA, the information is available // as a string using this method. virtual std::wstring GetExtraResult() = 0; - }; // Factory method for the native HTML Dialog. When done with the object use |