diff options
| author | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-05 01:34:05 +0000 |
|---|---|---|
| committer | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-05 01:34:05 +0000 |
| commit | 126f4623cb88b29c875795b61b3fdec2b9452462 (patch) | |
| tree | dcf1d78d5c8f90481fc3d4351d56b1b1734f5e1f /chrome/installer/util/util_constants.h | |
| parent | 5f3da203452e182901053f07b33ddfa0a22e337c (diff) | |
| download | chromium_src-126f4623cb88b29c875795b61b3fdec2b9452462.zip chromium_src-126f4623cb88b29c875795b61b3fdec2b9452462.tar.gz chromium_src-126f4623cb88b29c875795b61b3fdec2b9452462.tar.bz2 | |
Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty different methods.
Merge Quick Launch + Desktop logic into same call and add start menu shortcut logic in the mix too.
Make properties based API (like the one introduced in base/win/shortcut.h) with default values to simplify call sites who just want to create a basic Chrome shortcut.
shell_util.h:
(CreateChromeDesktopShortcut, CreateChromeQuickLaunchShortcut, UpdateChromeShortcut) => CreateOrUpdateChromeShortcut
(GetDesktopPath, GetQuickLaunchPath) => GetShortcutPath
(GetChromeShortcutName) => ChromeShortcutProperties::set_shortcut_name() (i.e. default name is GetAppShortcutName() unless set otherwise... special profile shortcut appending logic moved to ProfileShortcutManager::GetShortcutNameForProfile).
(RemoveChromeDesktopShortcut, RemoveChromeDesktopShortcutsWithAppendedNames) => RemoveChromeShortcut
install.h:
(CreateOrUpdateStartMenuAndTaskbarShortcuts, CreateOrUpdateDesktopAndQuickLaunchShortcuts) => CreateOrUpdateShortcuts (and incorporate some of the logic previously handled directly in InstallOrUpdateProduct()).
Finally thoroughly tests shell_util and install shortcut methods!
BUG=148539
TEST=Install chrome at user and system level with and without create_all_shortcuts master pref and make sure it works as intended in all scenarios.
installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest*
setup_unittests.exe --gtest_filter=InstallShortcutTest*
unit_tests.exe --gtest_filter=ProfileShortcutManagerTest*
Review URL: https://chromiumcodereview.appspot.com/10836247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160284 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util/util_constants.h')
| -rw-r--r-- | chrome/installer/util/util_constants.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/installer/util/util_constants.h b/chrome/installer/util/util_constants.h index 49e8c27..307c854 100644 --- a/chrome/installer/util/util_constants.h +++ b/chrome/installer/util/util_constants.h @@ -194,6 +194,7 @@ extern const wchar_t kInstallBinaryDir[]; extern const wchar_t kInstallerDir[]; extern const wchar_t kInstallTempDir[]; extern const wchar_t kInstallUserDataDir[]; +extern const wchar_t kLnkExt[]; extern const wchar_t kNaClExe[]; extern const wchar_t kSetupExe[]; extern const wchar_t kSxSSuffix[]; |