diff options
author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-09 02:26:37 +0000 |
---|---|---|
committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-09 02:26:37 +0000 |
commit | 968d2c518c9073e24ef3724886427481e68ae3e7 (patch) | |
tree | 371cd9ebde8b59cd6966ed42868c83672f8f9ec7 /chrome/installer/util | |
parent | 958fcc78b62c9a2afdfeaf8730658d18fe3cca70 (diff) | |
download | chromium_src-968d2c518c9073e24ef3724886427481e68ae3e7.zip chromium_src-968d2c518c9073e24ef3724886427481e68ae3e7.tar.gz chromium_src-968d2c518c9073e24ef3724886427481e68ae3e7.tar.bz2 |
Cleanup our Registry API.
- Use wchar_t instead of TCHAR.
- Use DCHECK instead of assert.
- Remove this keyword (we don't use it on chromium).
- Add DISALLOW_COPY_AND_ASSIGN to the classes.
- Make it more compliant with chromium code style.
- Remove ununsed methods.
- Use arraysize macro for array size calculation instead of doing it manually.
BUG=44644
TEST=trybots
TODO: Write unittests for this API.
TODO: Remove all the default arguments from the methods in this API. They aren't allowed by our style guide.
Review URL: http://codereview.chromium.org/3007037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55375 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util')
-rw-r--r-- | chrome/installer/util/google_update_settings_unittest.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/installer/util/google_update_settings_unittest.cc b/chrome/installer/util/google_update_settings_unittest.cc index e670a8e..11bd1fa 100644 --- a/chrome/installer/util/google_update_settings_unittest.cc +++ b/chrome/installer/util/google_update_settings_unittest.cc @@ -3,6 +3,7 @@ // found in the LICENSE file. #include <windows.h> +#include <shlwapi.h> // For SHDeleteKey. #include "base/registry.h" #include "base/scoped_ptr.h" @@ -13,9 +14,10 @@ #include "testing/gtest/include/gtest/gtest.h" namespace { -const wchar_t* kHKCUReplacement = + +const wchar_t kHKCUReplacement[] = L"Software\\Google\\InstallUtilUnittest\\HKCU"; -const wchar_t* kHKLMReplacement = +const wchar_t kHKLMReplacement[] = L"Software\\Google\\InstallUtilUnittest\\HKLM"; const wchar_t kTestProductGuid[] = L"{89F1B351-B15D-48D4-8F10-1298721CF13D}"; |