summaryrefslogtreecommitdiffstats
path: root/chrome/installer
diff options
context:
space:
mode:
authorfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-30 09:59:23 +0000
committerfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-30 09:59:23 +0000
commitb157419f15ec486b7553921479cb953a7a17c1f8 (patch)
tree2411913a40fd9ad0c17656f163144051e07651ee /chrome/installer
parent5ca03beb218b20971a6f8846d13106442f9e7e59 (diff)
downloadchromium_src-b157419f15ec486b7553921479cb953a7a17c1f8.zip
chromium_src-b157419f15ec486b7553921479cb953a7a17c1f8.tar.gz
chromium_src-b157419f15ec486b7553921479cb953a7a17c1f8.tar.bz2
Test out a new more compact, simpler attrition experiment toast bubble.
Old bubble: --------------------------------------------- There's a new safer version of Google Chrome [x] Try it out [ ] Uninstall [OK] [Don't Bug Me] {Why am I seeing this?} --------------------------------------------- Newer, more compact bubble: --------------------------------------------- There's a new safer version of Google Chrome [x] Try it out [ ] Don't Bug Me [OK] --------------------------------------------- BUG=None TEST=This should be tested like any other attrition toast experiment, but needs a special branded build. Review URL: https://chromiumcodereview.appspot.com/9129021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119655 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer')
-rw-r--r--chrome/installer/util/browser_distribution.h1
-rw-r--r--chrome/installer/util/google_chrome_distribution.cc17
2 files changed, 12 insertions, 6 deletions
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index 938440f..5f1b7b3 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -41,6 +41,7 @@ class BrowserDistribution {
// also known as the 'TV' part in 'TV80'.
int flavor; // The flavor index for this experiment.
int heading; // The heading resource ID to use for this experiment.
+ bool compact_bubble; // Whether to show the compact heading or not.
int control_group; // Size of the control group (in percentages). Control
// group is the group that qualifies for the
// experiment but does not participate.
diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc
index 0666178..73058d7 100644
--- a/chrome/installer/util/google_chrome_distribution.cc
+++ b/chrome/installer/util/google_chrome_distribution.cc
@@ -601,12 +601,16 @@ bool GoogleChromeDistribution::GetExperimentDetails(
// of headings (below).
int headings[kMax]; // A list of IDs per experiment. 0 == no heading.
} kExperimentFlavors[] = {
- // First in this order are the brand specific ones.
- {L"en-US", kSkype, 1, L'Z', L'A', 1, { kSkype1, 0, 0, 0 } },
- // And then we have catch-alls, like en-US (all brands).
- {L"en-US", kAll, 1, L'T', L'V', 4, { kEnUs1, kEnUs2, kEnUs3, kEnUs4} },
- // Japan has two experiments, same IDs as en-US but translated differently.
- {L"jp", kAll, 1, L'T', L'V', 2, { kEnUs1, kEnUs2, 0, 0} },
+ // This list should be ordered most-specific rule first (catch-all, like all
+ // brands or all locales should be last).
+
+ // The experiment with the more compact bubble. This one is a bit special
+ // because it is split into two: CAxx is regular style bubble and CBxx is
+ // compact style bubble. See |compact_bubble| below.
+ {L"en-US", kBrief, 1, L'C', L'A', 2, { kEnUs3, kEnUs3, 0, 0 } },
+
+ // Catch-all rules.
+ {kAll, kAll, 1, L'B', L'A', 1, {kEnUs3, 0, 0, 0} },
};
std::wstring locale;
@@ -657,6 +661,7 @@ bool GoogleChromeDistribution::GetExperimentDetails(
experiment->prefix.resize(2);
experiment->prefix[0] = kExperimentFlavors[i].prefix1;
experiment->prefix[1] = kExperimentFlavors[i].prefix2 + flavor;
+ experiment->compact_bubble = (brand == kBrief) && (flavor == 1);
return true;
}
}