diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-20 19:31:10 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-20 19:32:33 +0000 |
| commit | d4d772ea090aa8c073e93243ddee9c1258661cda (patch) | |
| tree | 23f1c6fe8346074a9504f3ca7c9234fd37afab90 /chrome/installer | |
| parent | 069c7b15ef037351d9f5771424bb6db80e5c92e0 (diff) | |
| download | chromium_src-d4d772ea090aa8c073e93243ddee9c1258661cda.zip chromium_src-d4d772ea090aa8c073e93243ddee9c1258661cda.tar.gz chromium_src-d4d772ea090aa8c073e93243ddee9c1258661cda.tar.bz2 | |
Don't pass const strings to CreateProcess.
The documentation says that CreateProcess() can modify its second parameter
in UNICODE builds.
BUG=396705
R=scottmg@chromium.org, vitalybuka@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/487303004
Cr-Commit-Position: refs/heads/master@{#290890}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290890 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer')
| -rw-r--r-- | chrome/installer/util/delete_tree_work_item_unittest.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/installer/util/delete_tree_work_item_unittest.cc b/chrome/installer/util/delete_tree_work_item_unittest.cc index 069f772..caa99e2 100644 --- a/chrome/installer/util/delete_tree_work_item_unittest.cc +++ b/chrome/installer/util/delete_tree_work_item_unittest.cc @@ -189,8 +189,9 @@ TEST_F(DeleteTreeWorkItemTest, DeleteTreeInUse) { // Run the key path file to keep it in use. STARTUPINFOW si = {sizeof(si)}; PROCESS_INFORMATION pi = {0}; + base::FilePath::StringType writable_key_path = key_path.value(); ASSERT_TRUE( - ::CreateProcessW(NULL, const_cast<wchar_t*>(key_path.value().c_str()), + ::CreateProcessW(NULL, &writable_key_path[0], NULL, NULL, FALSE, CREATE_NO_WINDOW | CREATE_SUSPENDED, NULL, NULL, &si, &pi)); |