diff options
| author | danakj <danakj@chromium.org> | 2015-01-08 15:35:58 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-08 23:37:17 +0000 |
| commit | e649f573a38b00bb20fe0925098251a4ff184566 (patch) | |
| tree | 6f400822726e85def4cad5a1ee704e232a6364ad /chrome/installer | |
| parent | 95bc5b1779dcf8e4a9e37ef600c0ea76293307e3 (diff) | |
| download | chromium_src-e649f573a38b00bb20fe0925098251a4ff184566.zip chromium_src-e649f573a38b00bb20fe0925098251a4ff184566.tar.gz chromium_src-e649f573a38b00bb20fe0925098251a4ff184566.tar.bz2 | |
base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().
This ensures that if the header is not included, and a DCHECK is guarded
by this check, that the file will fail to compile instead of silently
compiling the DCHECK out.
For example:
#if DCHECK_IS_ON
DCHECK(SomeThing());
#endif
This example would be compiled out if DCHECK_IS_ON was not defined due
to not including the logging.h header.
Instead, this will fail to compile:
#if DCHECK_IS_ON()
DCHECK(SomeThing());
#endif
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/842523002
Cr-Commit-Position: refs/heads/master@{#310626}
Diffstat (limited to 'chrome/installer')
| -rw-r--r-- | chrome/installer/util/shell_util.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc index 5a70fb9..469d10d 100644 --- a/chrome/installer/util/shell_util.cc +++ b/chrome/installer/util/shell_util.cc @@ -1282,7 +1282,7 @@ ShellUtil::DefaultState ProbeProtocolHandlers( const base::FilePath& chrome_exe, const wchar_t* const* protocols, size_t num_protocols) { -#if DCHECK_IS_ON +#if DCHECK_IS_ON() DCHECK(!num_protocols || protocols); for (size_t i = 0; i < num_protocols; ++i) DCHECK(protocols[i] && *protocols[i]); |