diff options
author | gregoryd@google.com <gregoryd@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-20 19:18:29 +0000 |
---|---|---|
committer | gregoryd@google.com <gregoryd@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-20 19:18:29 +0000 |
commit | 8cec5fa2488d84dcb0c4fe89ca72c027068b8792 (patch) | |
tree | 81c8d2bd509de2c2c5091808d04697d5c2d4b911 /chrome/installer | |
parent | 5ec779d955c6327802fbaaf655d24f41d13ade15 (diff) | |
download | chromium_src-8cec5fa2488d84dcb0c4fe89ca72c027068b8792.zip chromium_src-8cec5fa2488d84dcb0c4fe89ca72c027068b8792.tar.gz chromium_src-8cec5fa2488d84dcb0c4fe89ca72c027068b8792.tar.bz2 |
Reenable nacl_ui_tests on Windows + fix win64 issue.
Some functions in master_preferences_dummy.cc are now called but they are still not relevant for the 64-bit binary.
BUG=44371
Review URL: http://codereview.chromium.org/2115011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47825 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer')
-rw-r--r-- | chrome/installer/util/master_preferences_dummy.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/installer/util/master_preferences_dummy.cc b/chrome/installer/util/master_preferences_dummy.cc index 9abd037..3e1fb81 100644 --- a/chrome/installer/util/master_preferences_dummy.cc +++ b/chrome/installer/util/master_preferences_dummy.cc @@ -20,7 +20,8 @@ namespace installer_util { bool GetDistroBooleanPreference(const DictionaryValue* prefs, const std::wstring& name, bool* value) { - NOTREACHED(); + // This function is called by InstallUtil::IsChromeFrameProcess() + // We return false because GetInstallPreferences returns an empty value below. return false; } @@ -32,8 +33,9 @@ bool GetDistroIntegerPreference(const DictionaryValue* prefs, } DictionaryValue* GetInstallPreferences(const CommandLine& cmd_line) { - NOTREACHED(); - return NULL; + // This function is called by InstallUtil::IsChromeFrameProcess() + // so we cannot make it NOTREACHED() + return new DictionaryValue();; } DictionaryValue* ParseDistributionPreferences( |