diff options
| author | kuchhal@chromium.org <kuchhal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-24 22:22:15 +0000 |
|---|---|---|
| committer | kuchhal@chromium.org <kuchhal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-24 22:22:15 +0000 |
| commit | f844783017efd73e57900335f353f496857d4ecc (patch) | |
| tree | 7b3e4dd65980ab85713542bd42935e427c810d5c /chrome/installer | |
| parent | dfe34be0dcb38d5efd53ba1d714fce4b79b42c18 (diff) | |
| download | chromium_src-f844783017efd73e57900335f353f496857d4ecc.zip chromium_src-f844783017efd73e57900335f353f496857d4ecc.tar.gz chromium_src-f844783017efd73e57900335f353f496857d4ecc.tar.bz2 | |
Add error message to help debug install status inconsistency from logs.
Review URL: http://codereview.chromium.org/146097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer')
| -rw-r--r-- | chrome/installer/setup/install.cc | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc index 30c9442..24067d2 100644 --- a/chrome/installer/setup/install.cc +++ b/chrome/installer/setup/install.cc @@ -524,7 +524,13 @@ installer_util::InstallStatus installer::InstallOrUpdateChrome( LOG(INFO) << "Version updated to " << new_version.GetString(); result = installer_util::NEW_VERSION_UPDATED; } else { - NOTREACHED(); + LOG(ERROR) << "Not sure how we got here." + << " New version: " << new_version.GetString() + << ", installed version: " << installed_version->GetString(); + // This should never happen but we are seeing some inconsistent exit + // code reports in Omaha logs. We will treat this case as update to + // see if the inconsistency goes away. + result = installer_util::NEW_VERSION_UPDATED; } if (!CreateOrUpdateChromeShortcuts(exe_path, options, result, |