diff options
author | noelallen@google.com <noelallen@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-02 23:50:22 +0000 |
---|---|---|
committer | noelallen@google.com <noelallen@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-02 23:50:22 +0000 |
commit | 8f81ee73fab32f1a85526d7a49ec957627cff501 (patch) | |
tree | 58b3e347f0a21cd57a292b7e6b1c7955a9dbd099 /chrome/nacl.gypi | |
parent | 1d9b0c033ee6b04ac59a6caf96f34424cdf15cd8 (diff) | |
download | chromium_src-8f81ee73fab32f1a85526d7a49ec957627cff501.zip chromium_src-8f81ee73fab32f1a85526d7a49ec957627cff501.tar.gz chromium_src-8f81ee73fab32f1a85526d7a49ec957627cff501.tar.bz2 |
This CL is based on the patch:
http://codereview.chromium.org/8416025
Use GYP to build nacl_irt
Converts Chrome from using scons to using GYP when building nacl_irt.
This change causes chrome to use GYP based components for untrusted
code. As a benifit, GYP will no longer need to run and scrape scons
output to determine irt dependencies. This also allows us to avoid
invoking scons during the build process.
We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
issue on Windows.
This broke the mac build due to a missing dependency where pthread.h was
unavailable. This header gets copied to the correct location during the
prep_toolchain action. I've added the appropriate dependency shown bellow
to the original patch.
This add the addition dependency to ppruntime
'dependencies': [
'<(DEPTH)/native_client/src/tools.gyp:prep_toolchain'
],
TEST= try
BUG= http://code.google.com/p/chromium/issues/detail?id=96782
Review URL: http://codereview.chromium.org/8440004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108361 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/nacl.gypi')
-rw-r--r-- | chrome/nacl.gypi | 82 |
1 files changed, 8 insertions, 74 deletions
diff --git a/chrome/nacl.gypi b/chrome/nacl.gypi index 0e717b8..025de62 100644 --- a/chrome/nacl.gypi +++ b/chrome/nacl.gypi @@ -3,6 +3,9 @@ # found in the LICENSE file. { + 'includes': [ + '../native_client/build/untrusted.gypi', + ], 'target_defaults': { 'variables': { 'nacl_target': 0, @@ -62,16 +65,15 @@ 'type': 'static_library', 'variables': { 'nacl_target': 1, - 'irt_build_cmd': [ - 'python', 'build_nacl_irt.py', '--outdir', '<(PRODUCT_DIR)', - ], - 'irt_inputs_cmd': - 'python build_nacl_irt.py --inputs', - }, + }, 'dependencies': [ + # TODO(gregoryd): chrome_resources and chrome_strings could be + # shared with the 64-bit target, but it does not work due to a gyp + # issue 'chrome_resources', 'chrome_strings', 'common', + '../ppapi/native_client/native_client.gyp:nacl_irt', '../webkit/support/webkit_support.gyp:glue', '../ppapi/native_client/src/trusted/plugin/plugin.gyp:ppGoogleNaClPluginChrome', '../native_client/src/trusted/service_runtime/service_runtime.gyp:sel', @@ -84,74 +86,6 @@ '<@(nacl_defines)', ], }, - 'conditions': [ - ['OS=="win"', { - # Windows needs both the x86-32 and x86-64 IRT. - 'actions': [ - { - 'action_name': 'nacl_irt', - 'message': 'Building NaCl IRT', - 'inputs': [ - '<!@(<(irt_inputs_cmd) --platform=x86-32 --platform=x86-64)', - ], - 'outputs': ['<(PRODUCT_DIR)/nacl_irt_x86_32.nexe', - '<(PRODUCT_DIR)/nacl_irt_x86_64.nexe'], - 'action': [ - '<@(irt_build_cmd)', - '--platform', 'x86-32', - '--platform', 'x86-64', - ], - }, - ], - }], - ['OS!="win" and target_arch=="ia32"', { - # Linux-x86-32 and OSX need only the x86-32 IRT. - 'actions': [ - { - 'action_name': 'nacl_irt', - 'message': 'Building NaCl IRT', - 'inputs': [ - '<!@(<(irt_inputs_cmd) --platform=x86-32)', - ], - 'outputs': ['<(PRODUCT_DIR)/nacl_irt_x86_32.nexe'], - 'action': [ - '<@(irt_build_cmd)', '--platform', 'x86-32', - ], - }, - ], - }], - ['OS!="win" and target_arch=="x64"', { - # Linux-x86-64 needs only the x86-64 IRT. - 'actions': [ - { - 'action_name': 'nacl_irt', - 'message': 'Building NaCl IRT', - 'inputs': [ - '<!@(<(irt_inputs_cmd) --platform=x86-64)', - ], - 'outputs': ['<(PRODUCT_DIR)/nacl_irt_x86_64.nexe'], - 'action': [ - '<@(irt_build_cmd)', '--platform', 'x86-64', - ], - }, - ], - }], - ['OS!="win" and target_arch=="arm"', { - 'actions': [ - { - 'action_name': 'nacl_irt', - 'message': 'Building NaCl IRT', - 'inputs': [ - '<!@(<(irt_inputs_cmd) --platform=arm)', - ], - 'outputs': ['<(PRODUCT_DIR)/nacl_irt_arm.nexe'], - 'action': [ - '<@(irt_build_cmd)', '--platform', 'arm', - ], - }, - ], - }], - ], }, ], 'conditions': [ |