diff options
| author | dewittj@chromium.org <dewittj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-26 20:28:47 +0000 |
|---|---|---|
| committer | dewittj@chromium.org <dewittj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-26 20:28:47 +0000 |
| commit | 23e78de18f2b97d58eb10cd0246bae75ac41c787 (patch) | |
| tree | 806b13e2a3c1a4441875d27eaf9966da1a30d6db /chrome/nacl | |
| parent | 9cecc03af4a94a60dd1d5f548d41c47e372dd167 (diff) | |
| download | chromium_src-23e78de18f2b97d58eb10cd0246bae75ac41c787.zip chromium_src-23e78de18f2b97d58eb10cd0246bae75ac41c787.tar.gz chromium_src-23e78de18f2b97d58eb10cd0246bae75ac41c787.tar.bz2 | |
Revert 213933 "Move PPB_FileIO Query and Read implementation fro..."
Failures of PPAPITest.FileIO on Linux Tests (dbg)
> Move PPB_FileIO Query and Read implementation from the renderer to the plugin process.
> This sends the file descriptor to the plugin side and moves some FileIO
> implementation from the renderer to the plugin, using that file descriptor.
>
> BUG=194304
> R=dmichael@chromium.org, sky@chromium.org, teravest@chromium.org
>
> Review URL: https://codereview.chromium.org/18063005
TBR=bbudge@chromium.org
Review URL: https://codereview.chromium.org/20816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213976 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/nacl')
| -rw-r--r-- | chrome/nacl/nacl_ipc_adapter.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/nacl/nacl_ipc_adapter.cc b/chrome/nacl/nacl_ipc_adapter.cc index b143cf4..a257099 100644 --- a/chrome/nacl/nacl_ipc_adapter.cc +++ b/chrome/nacl/nacl_ipc_adapter.cc @@ -435,12 +435,6 @@ bool NaClIPCAdapter::OnMessageReceived(const IPC::Message& msg) { break; } case ppapi::proxy::SerializedHandle::FILE: - // IMPORTANT: The NaClDescIoDescFromHandleAllocCtor function creates - // a NaClDesc that checks file flags before reading and writing. This - // is essential since PPB_FileIO now sends a file descriptor to the - // plugin which may have write capabilities. We can't allow the plugin - // to write with it since it could bypass quota checks, which still - // happen in the host. nacl_desc.reset(new NaClDescWrapper(NaClDescIoDescFromHandleAllocCtor( #if defined(OS_WIN) iter->descriptor(), |