diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 02:18:30 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 02:18:30 +0000 |
commit | 8beff076f15f979f9334ad9f962444f57050fe52 (patch) | |
tree | f504f4c35856204e385fa12e2f3c8a45c6bdc6a8 /chrome/plugin/npobject_stub.h | |
parent | e67efe3af047fdf3ca4e62ed54cadf12b5bbbea2 (diff) | |
download | chromium_src-8beff076f15f979f9334ad9f962444f57050fe52.zip chromium_src-8beff076f15f979f9334ad9f962444f57050fe52.tar.gz chromium_src-8beff076f15f979f9334ad9f962444f57050fe52.tar.bz2 |
Get rid of the need for cross process events in order to get plugin processes to run nested message loops when a dialog is shown. Instead use an async message that's broadcast from the renderer to all plugin processes that are connected to it, and which is dispatched on the plugin IO thread to set a process-local waitable event. This fixes showModalDialog on Linux/Mac.
BUG=15891
TEST=covered by UI tests, undef's them for POSIX
Review URL: http://codereview.chromium.org/242043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27456 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin/npobject_stub.h')
-rw-r--r-- | chrome/plugin/npobject_stub.h | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/chrome/plugin/npobject_stub.h b/chrome/plugin/npobject_stub.h index 0f59290..6017f73 100644 --- a/chrome/plugin/npobject_stub.h +++ b/chrome/plugin/npobject_stub.h @@ -10,14 +10,11 @@ #include <vector> +#include "base/gfx/native_widget_types.h" #include "base/ref_counted.h" #include "googleurl/src/gurl.h" #include "ipc/ipc_channel.h" -namespace base { -class WaitableEvent; -} - class PluginChannelBase; class WebPluginDelegateProxy; struct NPIdentifier_Param; @@ -33,7 +30,7 @@ class NPObjectStub : public IPC::Channel::Listener, NPObjectStub(NPObject* npobject, PluginChannelBase* channel, int route_id, - base::WaitableEvent* modal_dialog_event, + gfx::NativeViewId containing_window, const GURL& page_url); ~NPObjectStub(); @@ -91,7 +88,7 @@ class NPObjectStub : public IPC::Channel::Listener, bool valid_; WebPluginDelegateProxy* web_plugin_delegate_proxy_; - base::WaitableEvent* modal_dialog_event_; + gfx::NativeViewId containing_window_; // The url of the main frame hosting the plugin. GURL page_url_; |