diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 20:32:41 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 20:32:41 +0000 |
commit | e4c0329c31debaec3b5fe8a1136321c143de7d97 (patch) | |
tree | 29609d0333ce7841305b942653085fb413e30b79 /chrome/plugin/webplugin_delegate_stub.cc | |
parent | 1ee61486ee0854be7b82d9fca66bb49d563ede4c (diff) | |
download | chromium_src-e4c0329c31debaec3b5fe8a1136321c143de7d97.zip chromium_src-e4c0329c31debaec3b5fe8a1136321c143de7d97.tar.gz chromium_src-e4c0329c31debaec3b5fe8a1136321c143de7d97.tar.bz2 |
linux: OOP windowed plugins
There are still a few issues, but that's a start.
- only windowed plugins
- we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID).
- the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC.
- some code is duplicated between chrome and test_shell. We should probably factor it, but I'm not sure where the common part should live.
Review URL: http://codereview.chromium.org/146078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19983 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin/webplugin_delegate_stub.cc')
-rw-r--r-- | chrome/plugin/webplugin_delegate_stub.cc | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/chrome/plugin/webplugin_delegate_stub.cc b/chrome/plugin/webplugin_delegate_stub.cc index e607667..3bfd002 100644 --- a/chrome/plugin/webplugin_delegate_stub.cc +++ b/chrome/plugin/webplugin_delegate_stub.cc @@ -128,14 +128,15 @@ void WebPluginDelegateStub::OnInit(const PluginMsg_Init_Params& params, FilePath path = FilePath::FromWStringHack( command_line.GetSwitchValue(switches::kPluginPath)); + + gfx::PluginWindowHandle parent = NULL; #if defined(OS_WIN) - delegate_ = WebPluginDelegate::Create( - path, mime_type_, gfx::NativeViewFromId(params.containing_window)); -#else - NOTIMPLEMENTED() << " need to figure out nativeview id business"; - delegate_ = WebPluginDelegate::Create( - path, mime_type_, NULL); + parent = gfx::NativeViewFromId(params.containing_window); +#elif defined(OS_LINUX) + PluginThread::current()->Send(new PluginProcessHostMsg_MapNativeViewId( + params.containing_window, &parent)); #endif + delegate_ = WebPluginDelegate::Create(path, mime_type_, parent); if (delegate_) { webplugin_ = new WebPluginProxy(channel_, instance_id_, delegate_); |