diff options
| author | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-31 19:33:22 +0000 |
|---|---|---|
| committer | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-31 19:33:22 +0000 |
| commit | 238e0655ef692535d62dd79b592322bba3eef65c (patch) | |
| tree | e90d60abed8d0ef8358ce87bbcd4f2982833b7d8 /chrome/plugin/webplugin_delegate_stub.cc | |
| parent | ec89db2ea6bfbcc169e3b58278643c9b32707fec (diff) | |
| download | chromium_src-238e0655ef692535d62dd79b592322bba3eef65c.zip chromium_src-238e0655ef692535d62dd79b592322bba3eef65c.tar.gz chromium_src-238e0655ef692535d62dd79b592322bba3eef65c.tar.bz2 | |
linux: disable querying the page window for windowless plugins
The problem is that the XID of the page window can change at arbitrary times
(e.g. when the tab is detached then reattached), so we need to be able to track
these changes, and let the PluginInstance know.
BUG=17110
TEST=go to www.nvidia.com, detach then reattach the tab, move the mouse, verify no crash
Review URL: http://codereview.chromium.org/180019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24916 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin/webplugin_delegate_stub.cc')
| -rw-r--r-- | chrome/plugin/webplugin_delegate_stub.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/plugin/webplugin_delegate_stub.cc b/chrome/plugin/webplugin_delegate_stub.cc index 9b33329..fda6909 100644 --- a/chrome/plugin/webplugin_delegate_stub.cc +++ b/chrome/plugin/webplugin_delegate_stub.cc @@ -145,8 +145,12 @@ void WebPluginDelegateStub::OnInit(const PluginMsg_Init_Params& params, #if defined(OS_WIN) parent = gfx::NativeViewFromId(params.containing_window); #elif defined(OS_LINUX) - PluginThread::current()->Send(new PluginProcessHostMsg_MapNativeViewId( - params.containing_window, &parent)); + // This code is disabled, See issue 17110. + // The problem is that the XID can change at arbitrary times (e.g. when the + // tab is detached then reattached), so we need to be able to track these + // changes, and let the PluginInstance know. + // PluginThread::current()->Send(new PluginProcessHostMsg_MapNativeViewId( + // params.containing_window, &parent)); #endif delegate_ = WebPluginDelegate::Create(path, mime_type_, parent); |