summaryrefslogtreecommitdiffstats
path: root/chrome/plugin/webplugin_proxy.cc
diff options
context:
space:
mode:
authorstuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-03 23:15:33 +0000
committerstuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-03 23:15:33 +0000
commit23607ccf23fce3ea302ba779a41e102fc3462dea (patch)
tree8a509d6c74efb53a335dacb23785a748cc6c7765 /chrome/plugin/webplugin_proxy.cc
parente150e821ae4aaeb16ed820724e1ca503de3c5319 (diff)
downloadchromium_src-23607ccf23fce3ea302ba779a41e102fc3462dea.zip
chromium_src-23607ccf23fce3ea302ba779a41e102fc3462dea.tar.gz
chromium_src-23607ccf23fce3ea302ba779a41e102fc3462dea.tar.bz2
Fix a bug in NPDrawingModelInvalidatingCoreAnimation, and make it more efficient
Fixes a conditional mistake introduced with the new drawing model. Skips unnecessary work when a NPDrawingModelInvalidatingCoreAnimation plugin calls invalidate. Removes some obsolete comments (the renaming in question already happened) BUG=None TEST=Core Animation plugins still work Review URL: http://codereview.chromium.org/2578004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48891 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin/webplugin_proxy.cc')
-rw-r--r--chrome/plugin/webplugin_proxy.cc9
1 files changed, 6 insertions, 3 deletions
diff --git a/chrome/plugin/webplugin_proxy.cc b/chrome/plugin/webplugin_proxy.cc
index 3bf1332..66f65fc 100644
--- a/chrome/plugin/webplugin_proxy.cc
+++ b/chrome/plugin/webplugin_proxy.cc
@@ -112,7 +112,12 @@ void WebPluginProxy::Invalidate() {
void WebPluginProxy::InvalidateRect(const gfx::Rect& rect) {
#if defined(OS_MACOSX)
- delegate_->PluginDidInvalidate();
+ // If this is a Core Animation plugin, all we need to do is inform the
+ // delegate.
+ if (!windowless_context_.get()) {
+ delegate_->PluginDidInvalidate();
+ return;
+ }
// Some plugins will send invalidates larger than their own rect when
// offscreen, so constrain invalidates to the plugin rect.
@@ -588,7 +593,6 @@ void WebPluginProxy::BindFakePluginWindowHandle(bool opaque) {
void WebPluginProxy::AcceleratedFrameBuffersDidSwap(
gfx::PluginWindowHandle window) {
- // TODO(pinkerton): Rename this message.
Send(new PluginHostMsg_AcceleratedSurfaceBuffersSwapped(route_id_, window));
}
@@ -596,7 +600,6 @@ void WebPluginProxy::SetAcceleratedSurface(gfx::PluginWindowHandle window,
int32 width,
int32 height,
uint64 accelerated_surface_identifier) {
- // TODO(pinkerton): Rename this message.
Send(new PluginHostMsg_AcceleratedSurfaceSetIOSurface(
route_id_, window, width, height, accelerated_surface_identifier));
}