diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-07 15:39:55 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-07 15:39:55 +0000 |
commit | 2799c02a46d0d8d2726f19c8b100ff67504a7349 (patch) | |
tree | 184426e3ce12615457a274e62ab3abcdf2152d81 /chrome/plugin/webplugin_proxy.h | |
parent | 2fa7c5c06d6fd30d23af3e71942d18d91eaf9b58 (diff) | |
download | chromium_src-2799c02a46d0d8d2726f19c8b100ff67504a7349.zip chromium_src-2799c02a46d0d8d2726f19c8b100ff67504a7349.tar.gz chromium_src-2799c02a46d0d8d2726f19c8b100ff67504a7349.tar.bz2 |
Amit, please review everything.
jam, please review changes to the plugin create channel IPCs.
mpcomplete, please review changes to chrome_plugin_host.cc
ChromeFrame needs to intercept URL requests issued directly by plugins like gears to ensure that they
get routed through the host browser network stack. We decide whether or not a request is to be handled
based on the renderer process id and the render view id (routing id), which get passed in the
ViewHostMsg_RequestResource IPC. If this request is issued by Gears then the routing id comes in as
MSG_ROUTING_NONE, which causes the request to go through the chrome network stack.
Fix is to pass the host render view id to the plugin in the PluginMsg_Init IPC. The plugin already
receives the renderer process id. Both these ids now come back in the ViewHostMsg_RequestResource
IPC.
This fixes an issue with wave when rendered in full tab mode in ChromeFrame, where dropping a file into
a wave would cause the renderer to hang.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=23992
Bug=23992
Review URL: http://codereview.chromium.org/370007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31387 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin/webplugin_proxy.h')
-rw-r--r-- | chrome/plugin/webplugin_proxy.h | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/chrome/plugin/webplugin_proxy.h b/chrome/plugin/webplugin_proxy.h index f75bd20..fbf88f6 100644 --- a/chrome/plugin/webplugin_proxy.h +++ b/chrome/plugin/webplugin_proxy.h @@ -34,7 +34,8 @@ class WebPluginProxy : public webkit_glue::WebPlugin { WebPluginProxy(PluginChannel* channel, int route_id, const GURL& page_url, - gfx::NativeViewId containing_window); + gfx::NativeViewId containing_window, + int host_render_view_routing_id); ~WebPluginProxy(); void set_delegate(WebPluginDelegateImpl* d) { delegate_ = d; } @@ -85,6 +86,11 @@ class WebPluginProxy : public webkit_glue::WebPlugin { // Returns the id of the renderer that contains this plugin. int GetRendererId(); + // Returns the id of the associated render view. + int host_render_view_routing_id() const { + return host_render_view_routing_id_; + } + // For windowless plugins, paints the given rectangle into the local buffer. void Paint(const gfx::Rect& rect); @@ -168,6 +174,9 @@ class WebPluginProxy : public webkit_glue::WebPlugin { #endif + // Contains the routing id of the host render view. + int host_render_view_routing_id_; + ScopedRunnableMethodFactory<WebPluginProxy> runnable_method_factory_; }; |