diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-16 23:00:15 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-16 23:00:15 +0000 |
| commit | 19cb929fa737ae5ef3c1425d38a793ef8967ee00 (patch) | |
| tree | 84801b2724d970541aa86f8a81d1f4b0c1d89ff6 /chrome/plugin | |
| parent | b3c064c2338e88a6ecfef7454bc3301d643a91fe (diff) | |
| download | chromium_src-19cb929fa737ae5ef3c1425d38a793ef8967ee00.zip chromium_src-19cb929fa737ae5ef3c1425d38a793ef8967ee00.tar.gz chromium_src-19cb929fa737ae5ef3c1425d38a793ef8967ee00.tar.bz2 | |
posix: handle the return value of close() in more places.
Generally, we don't expect it to fail and there isn't much we
can do anyway, but it's good to at least consider each case and
do something so we can continue to receive warnings in situations
where we forgot to check the return code.
(Bonus extra bugfix: use int where we previously had bool.
I think it compiles to the same thing but the old code was
definitely wrong.)
Review URL: http://codereview.chromium.org/1564037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44844 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin')
| -rw-r--r-- | chrome/plugin/plugin_channel.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/plugin/plugin_channel.cc b/chrome/plugin/plugin_channel.cc index c5913c3..b169b9e 100644 --- a/chrome/plugin/plugin_channel.cc +++ b/chrome/plugin/plugin_channel.cc @@ -326,7 +326,8 @@ bool PluginChannel::Init(MessageLoop* ipc_message_loop, bool create_pipe_now) { #if defined(OS_POSIX) void PluginChannel::CloseRendererFD() { if (renderer_fd_ != -1) { - HANDLE_EINTR(close(renderer_fd_)); + if (HANDLE_EINTR(close(renderer_fd_)) < 0) + PLOG(ERROR) << "close"; renderer_fd_ = -1; } } |