diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-20 21:38:12 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-20 21:38:12 +0000 |
commit | b692a128b073b297a4ce2aa7c468fdd37823e3a8 (patch) | |
tree | 3561224ba86e8eabd75f3e7a2f2343002d9a58ff /chrome/plugin | |
parent | b07c8d9a926a89d0aa7c0de2e1d2685b728a887e (diff) | |
download | chromium_src-b692a128b073b297a4ce2aa7c468fdd37823e3a8.zip chromium_src-b692a128b073b297a4ce2aa7c468fdd37823e3a8.tar.gz chromium_src-b692a128b073b297a4ce2aa7c468fdd37823e3a8.tar.bz2 |
Move the NPAPI files from webkit/glue/plugins to webkit/plugins/npapi and put
them in the webkit::npapi namespace.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6012002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69755 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin')
-rw-r--r-- | chrome/plugin/DEPS | 2 | ||||
-rw-r--r-- | chrome/plugin/chrome_plugin_host.cc | 6 | ||||
-rw-r--r-- | chrome/plugin/npobject_proxy.cc | 6 | ||||
-rw-r--r-- | chrome/plugin/npobject_stub.cc | 4 | ||||
-rw-r--r-- | chrome/plugin/npobject_util.cc | 4 | ||||
-rw-r--r-- | chrome/plugin/plugin_channel.cc | 8 | ||||
-rw-r--r-- | chrome/plugin/plugin_interpose_util_mac.mm | 18 | ||||
-rw-r--r-- | chrome/plugin/plugin_thread.cc | 10 | ||||
-rw-r--r-- | chrome/plugin/plugin_thread.h | 2 | ||||
-rw-r--r-- | chrome/plugin/webplugin_accelerated_surface_proxy_mac.h | 4 | ||||
-rw-r--r-- | chrome/plugin/webplugin_delegate_stub.cc | 19 | ||||
-rw-r--r-- | chrome/plugin/webplugin_delegate_stub.h | 6 | ||||
-rw-r--r-- | chrome/plugin/webplugin_proxy.cc | 10 | ||||
-rw-r--r-- | chrome/plugin/webplugin_proxy.h | 24 |
14 files changed, 71 insertions, 52 deletions
diff --git a/chrome/plugin/DEPS b/chrome/plugin/DEPS index 3517180..15434bf 100644 --- a/chrome/plugin/DEPS +++ b/chrome/plugin/DEPS @@ -5,7 +5,7 @@ include_rules = [ "+skia/ext", "+third_party/npapi", "+webkit/glue", - "+webkit/glue/plugins", + "+webkit/plugins", "+grit", # For generated headers ] diff --git a/chrome/plugin/chrome_plugin_host.cc b/chrome/plugin/chrome_plugin_host.cc index 22b3da9..8458e25 100644 --- a/chrome/plugin/chrome_plugin_host.cc +++ b/chrome/plugin/chrome_plugin_host.cc @@ -25,7 +25,7 @@ #include "net/base/upload_data.h" #include "net/http/http_response_headers.h" #include "webkit/appcache/appcache_interfaces.h" -#include "webkit/glue/plugins/plugin_instance.h" +#include "webkit/plugins/npapi/plugin_instance.h" #include "webkit/glue/resource_loader_bridge.h" #include "webkit/glue/resource_type.h" #include "webkit/glue/webkit_glue.h" @@ -415,8 +415,8 @@ CPBrowsingContext STDCALL CPB_GetBrowsingContextFromNPP(NPP npp) { if (!npp) return CPERR_INVALID_PARAMETER; - NPAPI::PluginInstance* instance = - static_cast<NPAPI::PluginInstance *>(npp->ndata); + webkit::npapi::PluginInstance* instance = + static_cast<webkit::npapi::PluginInstance *>(npp->ndata); WebPluginProxy* webplugin = static_cast<WebPluginProxy*>(instance->webplugin()); diff --git a/chrome/plugin/npobject_proxy.cc b/chrome/plugin/npobject_proxy.cc index f245151..0b7ff45 100644 --- a/chrome/plugin/npobject_proxy.cc +++ b/chrome/plugin/npobject_proxy.cc @@ -9,7 +9,7 @@ #include "chrome/plugin/plugin_channel.h" #include "third_party/WebKit/WebKit/chromium/public/WebBindings.h" #include "webkit/glue/webkit_glue.h" -#include "webkit/glue/plugins/plugin_instance.h" +#include "webkit/plugins/npapi/plugin_instance.h" using WebKit::WebBindings; @@ -460,8 +460,8 @@ bool NPObjectProxy::NPNEvaluate(NPP npp, bool popups_allowed = false; if (npp) { - NPAPI::PluginInstance* plugin_instance = - reinterpret_cast<NPAPI::PluginInstance*>(npp->ndata); + webkit::npapi::PluginInstance* plugin_instance = + reinterpret_cast<webkit::npapi::PluginInstance*>(npp->ndata); if (plugin_instance) popups_allowed = plugin_instance->popups_allowed(); } diff --git a/chrome/plugin/npobject_stub.cc b/chrome/plugin/npobject_stub.cc index c711756..e0a8436 100644 --- a/chrome/plugin/npobject_stub.cc +++ b/chrome/plugin/npobject_stub.cc @@ -12,7 +12,7 @@ #include "third_party/npapi/bindings/npapi.h" #include "third_party/npapi/bindings/npruntime.h" #include "third_party/WebKit/WebKit/chromium/public/WebBindings.h" -#include "webkit/glue/plugins/plugin_constants_win.h" +#include "webkit/plugins/npapi/plugin_constants_win.h" using WebKit::WebBindings; @@ -243,7 +243,7 @@ void NPObjectStub::OnSetProperty(const NPIdentifier_Param& name, PluginThread::current()->plugin_path().BaseName().value()); static NPIdentifier fullscreen = WebBindings::getStringIdentifier("fullScreen"); - if (filename == kNewWMPPlugin && id == fullscreen) { + if (filename == webkit::npapi::kNewWMPPlugin && id == fullscreen) { // Workaround for bug 15985, which is if Flash causes WMP to go // full screen a deadlock can occur when WMP calls SetFocus. NPObjectMsg_SetProperty::WriteReplyParams(reply_msg, true); diff --git a/chrome/plugin/npobject_util.cc b/chrome/plugin/npobject_util.cc index 0c54a33..60324cf 100644 --- a/chrome/plugin/npobject_util.cc +++ b/chrome/plugin/npobject_util.cc @@ -10,7 +10,7 @@ #include "chrome/plugin/plugin_channel_base.h" #include "third_party/npapi/bindings/nphostapi.h" #include "third_party/WebKit/WebKit/chromium/public/WebBindings.h" -#include "webkit/glue/plugins/plugin_host.h" +#include "webkit/plugins/npapi/plugin_host.h" #include "webkit/glue/webkit_glue.h" using WebKit::WebBindings; @@ -129,7 +129,7 @@ NPNetscapeFuncs *GetHostFunctions() { void PatchNPNFunctions() { g_plugin_process = true; NPNetscapeFuncs* funcs = GetHostFunctions(); - NPAPI::PluginHost::Singleton()->PatchNPNetscapeFuncs(funcs); + webkit::npapi::PluginHost::Singleton()->PatchNPNetscapeFuncs(funcs); } bool IsPluginProcess() { diff --git a/chrome/plugin/plugin_channel.cc b/chrome/plugin/plugin_channel.cc index b3b12951..bc5e61e 100644 --- a/chrome/plugin/plugin_channel.cc +++ b/chrome/plugin/plugin_channel.cc @@ -16,7 +16,7 @@ #include "chrome/plugin/plugin_thread.h" #include "chrome/plugin/webplugin_delegate_stub.h" #include "chrome/plugin/webplugin_proxy.h" -#include "webkit/glue/plugins/plugin_instance.h" +#include "webkit/plugins/npapi/plugin_instance.h" #if defined(OS_POSIX) #include "base/eintr_wrapper.h" @@ -256,12 +256,12 @@ void PluginChannel::OnClearSiteData(uint64 flags, bool success = false; CommandLine* command_line = CommandLine::ForCurrentProcess(); FilePath path = command_line->GetSwitchValuePath(switches::kPluginPath); - scoped_refptr<NPAPI::PluginLib> plugin_lib( - NPAPI::PluginLib::CreatePluginLib(path)); + scoped_refptr<webkit::npapi::PluginLib> plugin_lib( + webkit::npapi::PluginLib::CreatePluginLib(path)); if (plugin_lib.get()) { NPError err = plugin_lib->NP_Initialize(); if (err == NPERR_NO_ERROR) { - scoped_refptr<NPAPI::PluginInstance> instance( + scoped_refptr<webkit::npapi::PluginInstance> instance( plugin_lib->CreateInstance(std::string())); const char* domain_str = domain.empty() ? NULL : domain.c_str(); diff --git a/chrome/plugin/plugin_interpose_util_mac.mm b/chrome/plugin/plugin_interpose_util_mac.mm index 45df449..7299d4b 100644 --- a/chrome/plugin/plugin_interpose_util_mac.mm +++ b/chrome/plugin/plugin_interpose_util_mac.mm @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -9,7 +9,7 @@ #include "chrome/common/plugin_messages.h" #include "chrome/plugin/plugin_thread.h" -#include "webkit/glue/plugins/webplugin_delegate_impl.h" +#include "webkit/plugins/npapi/webplugin_delegate_impl.h" namespace mac_plugin_interposing { @@ -32,7 +32,7 @@ void SwitchToPluginProcess() { __attribute__((visibility("default"))) OpaquePluginRef GetActiveDelegate() { - return WebPluginDelegateImpl::GetActiveDelegate(); + return webkit::npapi::WebPluginDelegateImpl::GetActiveDelegate(); } __attribute__((visibility("default"))) @@ -72,13 +72,15 @@ void NotifyBrowserOfPluginHideWindow(uint32 window_id, CGRect bounds) { __attribute__((visibility("default"))) void NotifyPluginOfSetThemeCursor(OpaquePluginRef delegate, ThemeCursor cursor) { - static_cast<WebPluginDelegateImpl*>(delegate)->SetThemeCursor(cursor); + static_cast<webkit::npapi::WebPluginDelegateImpl*>(delegate)->SetThemeCursor( + cursor); } __attribute__((visibility("default"))) void NotifyPluginOfSetCursor(OpaquePluginRef delegate, const Cursor* cursor) { - static_cast<WebPluginDelegateImpl*>(delegate)->SetCursor(cursor); + static_cast<webkit::npapi::WebPluginDelegateImpl*>(delegate)->SetCursor( + cursor); } void NotifyPluginOfSetCursorVisibility(bool visibility) { @@ -91,7 +93,8 @@ void NotifyPluginOfSetCursorVisibility(bool visibility) { __attribute__((visibility("default"))) bool GetPluginWindowHasFocus(const OpaquePluginRef delegate) { - return static_cast<WebPluginDelegateImpl*>(delegate)->GetWindowHasFocus(); + return static_cast<webkit::npapi::WebPluginDelegateImpl*>( + delegate)->GetWindowHasFocus(); } } // namespace mac_plugin_interposing @@ -237,7 +240,8 @@ static void OnPluginWindowShown(const WindowInfo& window_info, BOOL is_modal) { - (void)chromePlugin_set { OpaquePluginRef delegate = mac_plugin_interposing::GetActiveDelegate(); if (delegate) { - static_cast<WebPluginDelegateImpl*>(delegate)->SetNSCursor(self); + static_cast<webkit::npapi::WebPluginDelegateImpl*>(delegate)->SetNSCursor( + self); return; } [self chromePlugin_set]; diff --git a/chrome/plugin/plugin_thread.cc b/chrome/plugin/plugin_thread.cc index 7e2b921..8edcbbd 100644 --- a/chrome/plugin/plugin_thread.cc +++ b/chrome/plugin/plugin_thread.cc @@ -29,9 +29,9 @@ #include "chrome/renderer/render_thread.h" #include "ipc/ipc_channel_handle.h" #include "net/base/net_errors.h" -#include "webkit/glue/plugins/plugin_lib.h" #include "webkit/glue/webkit_glue.h" -#include "webkit/glue/plugins/webplugin_delegate_impl.h" +#include "webkit/plugins/npapi/plugin_lib.h" +#include "webkit/plugins/npapi/webplugin_delegate_impl.h" #if defined(TOOLKIT_USES_GTK) #include "gfx/gtk_util.h" @@ -86,8 +86,8 @@ PluginThread::PluginThread() ChromePluginLib::Create(plugin_path_, GetCPBrowserFuncsForPlugin()); - scoped_refptr<NPAPI::PluginLib> plugin( - NPAPI::PluginLib::CreatePluginLib(plugin_path_)); + scoped_refptr<webkit::npapi::PluginLib> plugin( + webkit::npapi::PluginLib::CreatePluginLib(plugin_path_)); if (plugin.get()) { plugin->NP_Initialize(); @@ -115,7 +115,7 @@ PluginThread::~PluginThread() { preloaded_plugin_module_ = NULL; } PluginChannelBase::CleanupChannels(); - NPAPI::PluginLib::UnloadAllPlugins(); + webkit::npapi::PluginLib::UnloadAllPlugins(); ChromePluginLib::UnloadAllPlugins(); if (webkit_glue::ShouldForcefullyTerminatePluginProcess()) diff --git a/chrome/plugin/plugin_thread.h b/chrome/plugin/plugin_thread.h index 99d07ed..4d24e3c 100644 --- a/chrome/plugin/plugin_thread.h +++ b/chrome/plugin/plugin_thread.h @@ -11,7 +11,7 @@ #include "build/build_config.h" #include "chrome/common/child_thread.h" #include "chrome/plugin/plugin_channel.h" -#include "webkit/glue/plugins/plugin_lib.h" +#include "webkit/plugins/npapi/plugin_lib.h" #if defined(OS_POSIX) #include "base/file_descriptor_posix.h" diff --git a/chrome/plugin/webplugin_accelerated_surface_proxy_mac.h b/chrome/plugin/webplugin_accelerated_surface_proxy_mac.h index 8764ab9..ee4df63 100644 --- a/chrome/plugin/webplugin_accelerated_surface_proxy_mac.h +++ b/chrome/plugin/webplugin_accelerated_surface_proxy_mac.h @@ -6,7 +6,7 @@ #define CHROME_PLUGIN_WEBPLUGIN_ACCELERATED_SURFACE_PROXY_H_ #pragma once -#include "webkit/glue/plugins/webplugin_accelerated_surface_mac.h" +#include "webkit/plugins/npapi/webplugin_accelerated_surface_mac.h" class WebPluginProxy; class AcceleratedSurface; @@ -14,7 +14,7 @@ class AcceleratedSurface; // Out-of-process implementation of WebPluginAcceleratedSurface that proxies // calls through a WebPluginProxy. class WebPluginAcceleratedSurfaceProxy - : public webkit_glue::WebPluginAcceleratedSurface { + : public webkit::npapi::WebPluginAcceleratedSurface { public: // Creates a new WebPluginAcceleratedSurfaceProxy that uses plugin_proxy // to proxy calls. plugin_proxy must outlive this object. diff --git a/chrome/plugin/webplugin_delegate_stub.cc b/chrome/plugin/webplugin_delegate_stub.cc index ff0652d..0540adf 100644 --- a/chrome/plugin/webplugin_delegate_stub.cc +++ b/chrome/plugin/webplugin_delegate_stub.cc @@ -20,7 +20,7 @@ #include "skia/ext/platform_device.h" #include "third_party/WebKit/WebKit/chromium/public/WebBindings.h" #include "third_party/WebKit/WebKit/chromium/public/WebCursorInfo.h" -#include "webkit/glue/plugins/webplugin_delegate_impl.h" +#include "webkit/plugins/npapi/webplugin_delegate_impl.h" #include "webkit/glue/webcursor.h" #if defined(ENABLE_GPU) @@ -29,13 +29,15 @@ using WebKit::WebBindings; using WebKit::WebCursorInfo; -using webkit_glue::WebPlugin; -using webkit_glue::WebPluginResourceClient; +using webkit::npapi::WebPlugin; +using webkit::npapi::WebPluginResourceClient; class FinishDestructionTask : public Task { public: - FinishDestructionTask(WebPluginDelegateImpl* delegate, WebPlugin* webplugin) - : delegate_(delegate), webplugin_(webplugin) { } + FinishDestructionTask(webkit::npapi::WebPluginDelegateImpl* delegate, + WebPlugin* webplugin) + : delegate_(delegate), webplugin_(webplugin) { + } void Run() { // WebPlugin must outlive WebPluginDelegate. @@ -46,8 +48,8 @@ class FinishDestructionTask : public Task { } private: - WebPluginDelegateImpl* delegate_; - WebPlugin* webplugin_; + webkit::npapi::WebPluginDelegateImpl* delegate_; + webkit::npapi::WebPlugin* webplugin_; }; WebPluginDelegateStub::WebPluginDelegateStub( @@ -185,7 +187,8 @@ void WebPluginDelegateStub::OnInit(const PluginMsg_Init_Params& params, webplugin_ = new WebPluginProxy( channel_, instance_id_, page_url_, params.containing_window, params.host_render_view_routing_id); - delegate_ = WebPluginDelegateImpl::Create(path, mime_type_, parent); + delegate_ = webkit::npapi::WebPluginDelegateImpl::Create( + path, mime_type_, parent); if (delegate_) { webplugin_->set_delegate(delegate_); *result = delegate_->Initialize(params.url, diff --git a/chrome/plugin/webplugin_delegate_stub.h b/chrome/plugin/webplugin_delegate_stub.h index cbd2c97..c310467 100644 --- a/chrome/plugin/webplugin_delegate_stub.h +++ b/chrome/plugin/webplugin_delegate_stub.h @@ -29,7 +29,11 @@ namespace WebKit { class WebInputEvent; } +namespace webkit { +namespace npapi { class WebPluginDelegateImpl; +} +} // Converts the IPC messages from WebPluginDelegateProxy into calls to the // actual WebPluginDelegateImpl object. @@ -111,7 +115,7 @@ class WebPluginDelegateStub : public IPC::Channel::Listener, scoped_refptr<PluginChannel> channel_; - WebPluginDelegateImpl* delegate_; + webkit::npapi::WebPluginDelegateImpl* delegate_; WebPluginProxy* webplugin_; bool in_destructor_; diff --git a/chrome/plugin/webplugin_proxy.cc b/chrome/plugin/webplugin_proxy.cc index bb77108..498df98 100644 --- a/chrome/plugin/webplugin_proxy.cc +++ b/chrome/plugin/webplugin_proxy.cc @@ -34,16 +34,17 @@ #endif #include "skia/ext/platform_device.h" #include "third_party/WebKit/WebKit/chromium/public/WebBindings.h" -#include "webkit/glue/plugins/webplugin_delegate_impl.h" +#include "webkit/plugins/npapi/webplugin_delegate_impl.h" #if defined(USE_X11) #include "app/x11_util_internal.h" #endif using WebKit::WebBindings; -using webkit_glue::WebPluginResourceClient; + +using webkit::npapi::WebPluginResourceClient; #if defined(OS_MACOSX) -using webkit_glue::WebPluginAcceleratedSurface; +using webkit::npapi::WebPluginAcceleratedSurface; #endif typedef std::map<CPBrowsingContext, WebPluginProxy*> ContextMap; @@ -323,7 +324,8 @@ void WebPluginProxy::HandleURLRequest(const char* url, // Please refer to https://bugzilla.mozilla.org/show_bug.cgi?id=366082 // for more details on this. if (delegate_->GetQuirks() & - WebPluginDelegateImpl::PLUGIN_QUIRK_BLOCK_NONSTANDARD_GETURL_REQUESTS) { + webkit::npapi::WebPluginDelegateImpl:: + PLUGIN_QUIRK_BLOCK_NONSTANDARD_GETURL_REQUESTS) { GURL request_url(url); if (!request_url.SchemeIs(chrome::kHttpScheme) && !request_url.SchemeIs(chrome::kHttpsScheme) && diff --git a/chrome/plugin/webplugin_proxy.h b/chrome/plugin/webplugin_proxy.h index 66b396c..2a1f1aee 100644 --- a/chrome/plugin/webplugin_proxy.h +++ b/chrome/plugin/webplugin_proxy.h @@ -24,17 +24,23 @@ #include "chrome/common/chrome_plugin_api.h" #include "googleurl/src/gurl.h" #include "ipc/ipc_message.h" -#include "webkit/glue/plugins/webplugin.h" +#include "webkit/plugins/npapi/webplugin.h" class PluginChannel; + +namespace webkit { +namespace npapi { class WebPluginDelegateImpl; +} +} + #if defined(OS_MACOSX) class WebPluginAcceleratedSurfaceProxy; #endif // This is an implementation of WebPlugin that proxies all calls to the // renderer. -class WebPluginProxy : public webkit_glue::WebPlugin { +class WebPluginProxy : public webkit::npapi::WebPlugin { public: // Creates a new proxy for WebPlugin, using the given sender to send the // marshalled WebPlugin calls. @@ -45,7 +51,7 @@ class WebPluginProxy : public webkit_glue::WebPlugin { int host_render_view_routing_id); ~WebPluginProxy(); - void set_delegate(WebPluginDelegateImpl* d) { delegate_ = d; } + void set_delegate(webkit::npapi::WebPluginDelegateImpl* d) { delegate_ = d; } // WebPlugin overrides virtual void SetWindow(gfx::PluginWindowHandle window); @@ -93,7 +99,7 @@ class WebPluginProxy : public webkit_glue::WebPlugin { // Returns a WebPluginResourceClient object given its id, or NULL if no // object with that id exists. - webkit_glue::WebPluginResourceClient* GetResourceClient(int id); + webkit::npapi::WebPluginResourceClient* GetResourceClient(int id); // Returns the id of the renderer that contains this plugin. int GetRendererId(); @@ -111,7 +117,7 @@ class WebPluginProxy : public webkit_glue::WebPlugin { // Notification received on a plugin issued resource request creation. void OnResourceCreated(int resource_id, - webkit_glue::WebPluginResourceClient* client); + webkit::npapi::WebPluginResourceClient* client); virtual void HandleURLRequest(const char* url, const char* method, @@ -137,7 +143,7 @@ class WebPluginProxy : public webkit_glue::WebPlugin { virtual void SetDeferResourceLoading(unsigned long resource_id, bool defer); virtual bool IsOffTheRecord(); virtual void ResourceClientDeleted( - webkit_glue::WebPluginResourceClient* resource_client); + webkit::npapi::WebPluginResourceClient* resource_client); gfx::NativeViewId containing_window() { return containing_window_; } #if defined(OS_MACOSX) @@ -145,7 +151,7 @@ class WebPluginProxy : public webkit_glue::WebPlugin { virtual void BindFakePluginWindowHandle(bool opaque); - virtual webkit_glue::WebPluginAcceleratedSurface* GetAcceleratedSurface(); + virtual webkit::npapi::WebPluginAcceleratedSurface* GetAcceleratedSurface(); // Tell the browser (via the renderer) to invalidate because the // accelerated buffers have changed. @@ -189,7 +195,7 @@ class WebPluginProxy : public webkit_glue::WebPlugin { const TransportDIB::Handle& background_buffer, const gfx::Rect& window_rect); - typedef base::hash_map<int, webkit_glue::WebPluginResourceClient*> + typedef base::hash_map<int, webkit::npapi::WebPluginResourceClient*> ResourceClientMap; ResourceClientMap resource_clients_; @@ -198,7 +204,7 @@ class WebPluginProxy : public webkit_glue::WebPlugin { uint32 cp_browsing_context_; NPObject* window_npobject_; NPObject* plugin_element_; - WebPluginDelegateImpl* delegate_; + webkit::npapi::WebPluginDelegateImpl* delegate_; gfx::Rect damaged_rect_; bool waiting_for_paint_; gfx::NativeViewId containing_window_; |