summaryrefslogtreecommitdiffstats
path: root/chrome/plugin
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-26 19:39:29 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-26 19:39:29 +0000
commit096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0 (patch)
treeb59e549c2ae6733f3d675a8982d109088adcea51 /chrome/plugin
parent540f91b592b8a500442bccdebffbd34a4d8bc1bd (diff)
downloadchromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.zip
chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.tar.gz
chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.tar.bz2
Report the plugin position to windowed plugins as (0,0)
. the NPAPI documentation says it should be reported relative to the parent HWND, which is the plugin's coordinates on the page. This assumption breaks in Chrome because we have an intermediate HWND. I've tested on a bunch of pages to see if this change causes regressions, if we find any in the future we can reconsider this. BUG=6742 Review URL: http://codereview.chromium.org/42626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin')
-rw-r--r--chrome/plugin/webplugin_proxy.cc4
-rw-r--r--chrome/plugin/webplugin_proxy.h2
2 files changed, 4 insertions, 2 deletions
diff --git a/chrome/plugin/webplugin_proxy.cc b/chrome/plugin/webplugin_proxy.cc
index 352e287..dbe9b5a 100644
--- a/chrome/plugin/webplugin_proxy.cc
+++ b/chrome/plugin/webplugin_proxy.cc
@@ -70,7 +70,7 @@ bool WebPluginProxy::Send(IPC::Message* msg) {
return channel_->Send(msg);
}
-void WebPluginProxy::SetWindow(HWND window, HANDLE pump_messages_event) {
+bool WebPluginProxy::SetWindow(HWND window, HANDLE pump_messages_event) {
HANDLE pump_messages_event_for_renderer = NULL;
if (pump_messages_event) {
@@ -104,6 +104,8 @@ void WebPluginProxy::SetWindow(HWND window, HANDLE pump_messages_event) {
Send(new PluginHostMsg_SetWindow(route_id_, window,
pump_messages_event_for_renderer));
+
+ return false;
}
void WebPluginProxy::CancelResource(int id) {
diff --git a/chrome/plugin/webplugin_proxy.h b/chrome/plugin/webplugin_proxy.h
index c51769d..78ca43c 100644
--- a/chrome/plugin/webplugin_proxy.h
+++ b/chrome/plugin/webplugin_proxy.h
@@ -35,7 +35,7 @@ class WebPluginProxy : public WebPlugin {
~WebPluginProxy();
// WebPlugin overrides
- void SetWindow(HWND window, HANDLE pump_messages_event);
+ bool SetWindow(HWND window, HANDLE pump_messages_event);
void CancelResource(int id);
void Invalidate();
void InvalidateRect(const gfx::Rect& rect);