diff options
| author | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-07 00:34:55 +0000 |
|---|---|---|
| committer | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-07 00:34:55 +0000 |
| commit | 56fcc3f051d030df1195fc543b93fca550b4e8e0 (patch) | |
| tree | a6b3dab85957beb109c1d34e68dc1f0c2a6b6435 /chrome/plugin | |
| parent | 37095fe7d4408ba30977c59f6f3cb7f985ba34f0 (diff) | |
| download | chromium_src-56fcc3f051d030df1195fc543b93fca550b4e8e0.zip chromium_src-56fcc3f051d030df1195fc543b93fca550b4e8e0.tar.gz chromium_src-56fcc3f051d030df1195fc543b93fca550b4e8e0.tar.bz2 | |
linux: fix windowless Flash when scrolling
Apparently on linux windowless Flash needs a paint after a NPP_SetWindow, otherwise it cancels its timer to do InvalidateRect.
Also in this change: WebKit calls WebPluginImpl::setFrameRect at each paint, even if the rects haven't changed. That used to always send a message to the plugin process, which is unnecessary (that case is always a no-op in the WebPluginDelegateImpl), so I fixed that too.
BUG=18423
Review URL: http://codereview.chromium.org/159907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22702 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin')
| -rw-r--r-- | chrome/plugin/webplugin_proxy.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/plugin/webplugin_proxy.cc b/chrome/plugin/webplugin_proxy.cc index 6aee645..0e2e006 100644 --- a/chrome/plugin/webplugin_proxy.cc +++ b/chrome/plugin/webplugin_proxy.cc @@ -182,6 +182,12 @@ void WebPluginProxy::InvalidateRect(const gfx::Rect& rect) { // Ignore NPN_InvalidateRect calls with empty rects. Also don't send an // invalidate if it's outside the clipping region, since if we did it won't // lead to a paint and we'll be stuck waiting forever for a DidPaint response. + // + // TODO(piman): There is a race condition here, because this test assumes + // that when the paint actually occurs, the clip rect will not have changed. + // This is not true because scrolling (or window resize) could occur and be + // handled by the renderer before it receives the InvalidateRect message, + // changing the clip rect and then not painting. if (rect.IsEmpty() || !delegate_->GetClipRect().Intersects(rect)) return; |