summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/automation
diff options
context:
space:
mode:
authorisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-30 21:50:05 +0000
committerisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-30 21:50:05 +0000
commit9fabbf77b5b467003287b055aece906a4330de86 (patch)
tree3727f1d511342a55c9ece39c7a7b264f027081f8 /chrome/renderer/automation
parentee520884a87f24a5e34ef660657d49f2ec993f6e (diff)
downloadchromium_src-9fabbf77b5b467003287b055aece906a4330de86.zip
chromium_src-9fabbf77b5b467003287b055aece906a4330de86.tar.gz
chromium_src-9fabbf77b5b467003287b055aece906a4330de86.tar.bz2
Make ui_test_utils::ExecuteJavaScript() friendlier to use. Also, add WARN_UNUSED_RESULT to make it less likely that callers ignore failures.
BUG=57216 TEST=tests should still run Review URL: http://codereview.chromium.org/3569005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61119 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/automation')
-rw-r--r--chrome/renderer/automation/dom_automation_controller.cc10
1 files changed, 4 insertions, 6 deletions
diff --git a/chrome/renderer/automation/dom_automation_controller.cc b/chrome/renderer/automation/dom_automation_controller.cc
index 6c3e8a5..8d708d1 100644
--- a/chrome/renderer/automation/dom_automation_controller.cc
+++ b/chrome/renderer/automation/dom_automation_controller.cc
@@ -72,19 +72,17 @@ void DomAutomationController::Send(const CppArgumentList& args,
}
}
- bool succeeded = serializer.Serialize(*value);
- if (!succeeded) {
+ if (!serializer.Serialize(*value)) {
result->SetNull();
return;
}
- succeeded = sender_->Send(
- new ViewHostMsg_DomOperationResponse(routing_id_, json, automation_id_));
+ bool succeeded = sender_->Send(
+ new ViewHostMsg_DomOperationResponse(routing_id_, json, automation_id_));
+ result->Set(succeeded);
automation_id_ = MSG_ROUTING_NONE;
- result->Set(succeeded);
- return;
}
void DomAutomationController::SendJSON(const CppArgumentList& args,